fix(circuit): partial perms bug fix

[tac0turtle]

…able to trip them

Description

Closes: #17106

Fix a bug where a user with permission for two messages would not be able to trip them

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

I think if the first message is unauthorized but the second is you’ll still be able to trip it with the current logic.

[tac0turtle]

we test this here:

cosmos-sdk/x/circuit/keeper/msg_server_test.go

Line 194 in f7fe337

require.ErrorContains(t, err, "MsgEditValidator: unauthorized")

, i was thinking the same when i read it at first then ran the test

[julienrbrt]

Yep, my bad I didn't see the surrounding loop from the diff 👍🏾