Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bank): avoid empty spendable error message on send coins #17170

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix(bank): avoid empty spendable error message on send coins #17170

merged 3 commits into from
Jul 28, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 28, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mmsqe mmsqe marked this pull request as ready for review July 28, 2023 01:27
@mmsqe mmsqe requested a review from a team as a code owner July 28, 2023 01:27
julienrbrt
julienrbrt approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! tACK!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 28, 2023
@julienrbrt julienrbrt changed the title fix: avoid empty spendable error message on send coins fix(bank): avoid empty spendable error message on send coins Jul 28, 2023
@mmsqe
Copy link
Contributor Author

mmsqe commented Jul 28, 2023

Good find! tACK!

Is it ok that we backport to v0.47.x as well?

@julienrbrt
Copy link
Member

Good find! tACK!

Is it ok that we backport to v0.47.x as well?

I don't think so. This could be consensus breaking I believe.

@mmsqe
Copy link
Contributor Author

mmsqe commented Jul 28, 2023

I don't think so. This could be consensus breaking I believe.

Actually error code is the same, only error message change.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 28, 2023
Merged via the queue into cosmos:main with commit 009a152 Jul 28, 2023
49 checks passed
@mergify mergify bot mentioned this pull request Jul 28, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 28, 2023
@mmsqe @mergify
fix(bank): avoid empty spendable error message on send coins (#17170)
8f3d9b3 
(cherry picked from commit 009a152)
julienrbrt pushed a commit that referenced this pull request Jul 28, 2023
@mergify @mmsqe
fix(bank): avoid empty spendable error message on send coins (backport …
7e7e15d 
…#17170) (#17179)

Co-authored-by: mmsqe <mavis@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp atheeshp approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsqe @julienrbrt @atheeshp