refactor(simapp): add ,squash tag
#17172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
changed the title
,squash flag,squash flag
julienrbrt
added
the
backport/v0.50.x
julienrbrt
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Thanks!
For ref:
// Squash will squash embedded structs. A squash tag may also be
// added to an individual struct field using a tag. For example:
//
// type Parent struct {
// Childmapstructure:",squash"
// }
Squash bool
https://pkg.go.dev/github.com/mitchellh/mapstructure#section-readme
julienrbrt
changed the title
,squash flag,squash tag
julienrbrt
pushed a commit
that referenced
this pull request
Jul 28, 2023
Co-authored-by: zakir-code <80246097+zakir-code@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid being unable to directly parse the data in
viperinto CustomAppConfig throughviper.Unmarshal(config), althoughCustomAppConfighere is not used, but I think it should be demonstrated in simapp.