Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gov,group): allow draft-proposal to skip metatada prompt #17220

Merged
merged 5 commits into from
Aug 1, 2023
Merged

feat(gov,group): allow draft-proposal to skip metatada prompt #17220

merged 5 commits into from
Aug 1, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 31, 2023 •
edited
Loading

Description

It is annoying to always have to specify the metadata. This add a flag to skip it.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 31, 2023
@julienrbrt julienrbrt marked this pull request as ready for review July 31, 2023 14:47
@julienrbrt julienrbrt requested a review from a team as a code owner July 31, 2023 14:47
@github-actions

This comment has been minimized.

Sign in to view
@julienrbrt julienrbrt changed the title feat(gov,group): improve draft-proposal prompt feat(gov,group): allow draft-proposal to skip metatada prompt Jul 31, 2023
likhita-809
likhita-809 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
can you test this locally?

@julienrbrt
Copy link
Member Author

lgtm can you test this locally?

I have :)

@julienrbrt julienrbrt removed the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Aug 1, 2023
julienrbrt
julienrbrt commented Aug 1, 2023
View reviewed changes
x/gov/client/cli/prompt.go
Validate: client.ValidatePromptNotEmpty,
}

fieldName := strings.ToLower(v.Type().Field(i).Name)
// validation per field name
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this as this can collide with msg type url which is definitely not a web url.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 5de3700 Aug 1, 2023
46 checks passed
@julienrbrt julienrbrt deleted the julien/impr-prompt branch August 1, 2023 11:04
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
@julienrbrt @mergify
feat(gov,group): allow draft-proposal to skip metatada prompt (#17220)
169a6f8 
(cherry picked from commit 5de3700)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
@julienrbrt @mergify
feat(gov,group): allow draft-proposal to skip metatada prompt (#17220)
ef5a936 
(cherry picked from commit 5de3700)

# Conflicts:
#	CHANGELOG.md
This was referenced Aug 1, 2023
Merged
Merged
julienrbrt added a commit that referenced this pull request Aug 1, 2023
@mergify @julienrbrt
feat(gov,group): allow draft-proposal to skip metatada prompt (back…
2e76cae 
…port #17220) (#17243)

Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Aug 1, 2023
@mergify @julienrbrt
feat(gov,group): allow draft-proposal to skip metatada prompt (back…
f42be24 
…port #17220) (#17242)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@PoisonPhang PoisonPhang mentioned this pull request Sep 12, 2023
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jun 18, 2024
Closed
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/gov C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @likhita-809