chore(baseapp): audit #17325
Merged
chore(baseapp): audit #17325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
725
to
+732
| } | ||
| } | ||
|
|
||
| beginBlock := app.beginBlock(req) | ||
| beginBlock, err := app.beginBlock(req) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:658)
julienrbrt
commented
Aug 8, 2023
| @@ -201,7 +201,7 @@ func (h DefaultProposalHandler) PrepareProposalHandler() sdk.PrepareProposalHand | |||
| if err != nil { | |||
| err := h.mempool.Remove(memTx) | |||
| if err != nil && !errors.Is(err, mempool.ErrTxNotFound) { | |||
| panic(err) | |||
| return nil, err | |||
There was a problem hiding this comment.
We would be recovering the panic anyway, so not sure what was the benefit of panicking.
alexanderbez
approved these changes
Aug 9, 2023
tac0turtle
approved these changes
Aug 10, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 731d727)
julienrbrt
added a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16474
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change