-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove collections.ErrInvalidIterator when unecessary #17367
Conversation
@@ -4,7 +4,7 @@ module github.com/cosmos/cosmos-sdk | |||
|
|||
require ( | |||
cosmossdk.io/api v0.7.0 | |||
cosmossdk.io/collections v0.3.0 | |||
cosmossdk.io/collections v0.3.1-0.20230808102719-f04fefdc7a68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@testinginprod, it would be great to get a new version before v0.50 final.
I remember you said you were waiting for something last time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for go 1.21, this has improvements on type inference that should make certain things in collections better, this will cause some breaking changes on collections.
unfortunately, I'm not sure if this will happen before we cut v0.50 final.
when there's intention to cut v0.50 final let me know, and I'll cut collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@testinginprod would you want to create a branch with go 1.21 changes to collections that way once we merge jullians pr we can merge yours and get it into 0.50
Description
Target v0.50 branch.
ref: #17364
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change