fix(client/v2): fix duplicate modules addition and add logger #17390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
|
@julienrbrt your pull request is missing a changelog! |
No changelog needed for client/v2. |
julienrbrt
force-pushed
the
julien/autocli-logger-and-dup
branch
from
9fe7f60
to
4b494a0
Compare
tac0turtle
approved these changes
Aug 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
(cherry picked from commit dded2e9) # Conflicts: # client/v2/go.mod # x/crisis/autocli.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a logger to client/v2. Note, by default the logging is disabled in client/v2 if no logger is provided.
In root_v2 we supply a no-op logger so it is as well disabled by default.
While playing with it, it surfaced a bug where it could happen that some subcommands could be added due to duplicate module keys.
Additionally, duplicate subcommands would not be correctly enhanced. This is fixed here as well.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change