fix(ve-validation): account for BlockID flag in vote-extensions

[nivasan1]

Description

Closes: #17393

In This PR

• I check that the only votes validated in ValidateVoteExtensions are votes that have BlockIDCommit, in other words, vote-extensions that accompanied pre-commits for the previous block. In this case, the block must have come w/ > super-majority of such votes
• I also add an extensive test-suite of the ValidateVoteExtensions method, covering the cases leading to the above issue.

Files Changed

• baseapp/abci_utils.go (changed)
• baseapp/abci_utils_test.go (added)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• [ x] included the correct type prefix in the PR title
• [NA ] added ! to the type prefix if API or client breaking change
• [ x] targeted the correct branch (see PR Targeting)
• [x ] provided a link to the relevant issue or specification
• [ x] followed the guidelines for building modules
• [x ] included the necessary unit and integration tests
• [x ] added a changelog entry to CHANGELOG.md
• [x ] included comments for documenting Go code
• [x ] updated the relevant documentation or specification
• [ x] reviewed "Files changed" and left comments if necessary
• [x ] run make lint and make test
• [ x] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

Thanks for the tests too!

[julienrbrt]

It seems you need to run make lint-fix to get CI happy.

[nivasan1]

Wondering specifically what the issue is w/ the linter? I'm attempting to run locally, and make lint-fix / make lint fail in execution locally (+ attempt to change files that were not involved in PR), when setting the LINT_DIFF env, the affected files in PR are unchanged?

[alexanderbez]

Mhhh weird.

abci_utils_test.go:286: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order (gci)

This should be addressed with a simple make lint-fix and pushing the changes.

[nivasan1]

pushing

Mhhh weird.

abci_utils_test.go:286: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order (gci)

This should be addressed with a simple make lint-fix and pushing the changes.

Perhaps a misconfig locally, I was able to find manually 🚢

[nivasan1]

@alexanderbez looks like linting + test-cases passed, but final stage in pushing to sonarcloud failed for repo-analysis? Is there any way I can inspect the logs from the failure?

[julienrbrt]

@alexanderbez looks like linting + test-cases passed, but final stage in pushing to sonarcloud failed for repo-analysis? Is there any way I can inspect the logs from the failure?

Sonarcloud does not work for external contributors, so it is fine 👍🏾

[nivasan1]

@alexanderbez looks like linting + test-cases passed, but final stage in pushing to sonarcloud failed for repo-analysis? Is there any way I can inspect the logs from the failure?

Sonarcloud does not work for external contributors, so it is fine 👍🏾

Sg, anything left before merge?