refactor: remove header type from NewContext #17426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/staking
C:x/gov
C:x/slashing
C:x/distribution
github-prbot
requested review from
a team,
samricotta and
atheeshp
and removed request for
a team
alexanderbez
approved these changes
Aug 18, 2023
julienrbrt
approved these changes
Aug 18, 2023
julienrbrt
reviewed
Aug 18, 2023
julienrbrt
reviewed
Aug 18, 2023
julienrbrt
reviewed
Aug 19, 2023
testinginprod
approved these changes
Aug 21, 2023
julienrbrt
reviewed
Aug 21, 2023
julienrbrt
reviewed
Aug 21, 2023
| @@ -156,6 +159,9 @@ func (c Context) WithBlockHeader(header cmtproto.Header) Context { | |||
| // https://github.com/gogo/protobuf/issues/519 | |||
| header.Time = header.Time.UTC() | |||
| c.header = header | |||
|
|
|||
| // when calling withBlockheader on a new context chainID in the struct is empty | |||
| c.chainID = header.ChainID | |||
There was a problem hiding this comment.
Do we expect WithChainID to have the same behavior? (Set the chainID to the header?).
Currently in all SDK versions, it does not do it.
There was a problem hiding this comment.
tbh this is weird, the chainID is in the header and on the struct, but they werent updated together, I think this is two bugs, first storing it twice second not updating or checking the other when updating one of them
There was a problem hiding this comment.
+1, I think this is a valid fix of WithBlockHeader / WithChainID that we can add to in least v0.50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #17425
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change