Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/tx): add custom type encoder #17681

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 11, 2023

Description

Based on #17600, so #17600 should be merged first.
Unblocks #16985


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review September 11, 2023 16:32
@julienrbrt julienrbrt requested a review from a team as a code owner September 11, 2023 16:32
@julienrbrt julienrbrt marked this pull request as draft September 11, 2023 16:38
@julienrbrt julienrbrt marked this pull request as ready for review September 11, 2023 16:50
@julienrbrt julienrbrt changed the title feat(x/tx): add indent option to encoder feat(x/tx): add custom type encoder Sep 11, 2023
Base automatically changed from julien/encoder-indent to main September 11, 2023 17:06
@julienrbrt julienrbrt requested review from kocubinski, a team and alexanderbez and removed request for a team September 11, 2023 17:13
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added this pull request to the merge queue Sep 13, 2023
@julienrbrt
Copy link
Member Author

I want to wait for a formal ACK from you @kocubinski before tagging.
However, merging now to move things further with AutoCLI, will use a pseudo version from main in the meantime.

Merged via the queue into main with commit e394604 Sep 13, 2023
53 checks passed
@julienrbrt julienrbrt deleted the julien/encoder-custom-type-encoder branch September 13, 2023 11:21
Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to slow you down @julienrbrt, it LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants