-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce PreBlock (backport #17421) #17712
Merged
julienrbrt
merged 6 commits into
release/v0.50.x
from
mergify/bp/release/v0.50.x/pr-17421
Sep 13, 2023
Merged
feat: introduce PreBlock (backport #17421) #17712
julienrbrt
merged 6 commits into
release/v0.50.x
from
mergify/bp/release/v0.50.x/pr-17421
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4eb0185) # Conflicts: # CHANGELOG.md # UPGRADING.md # docs/docs/build/building-apps/03-app-upgrade.md # docs/docs/build/building-modules/01-module-manager.md # docs/docs/develop/advanced/00-baseapp.md # runtime/builder.go # simapp/go.mod # simapp/go.sum # simapp/gomod2nix.toml # tests/go.mod # tests/go.sum # tests/starship/tests/go.mod # tests/starship/tests/go.sum # testutil/mock/types_mock_appmodule.go # types/module/module.go # types/module/module_test.go # x/feegrant/go.mod # x/upgrade/abci.go # x/upgrade/abci_test.go # x/upgrade/go.mod # x/upgrade/go.sum
github-actions
bot
added
C:x/evidence
C:x/upgrade
C:x/feegrant
C:x/nft
Type: ADR
C:x/circuit
labels
Sep 13, 2023
github-prbot
requested review from
tac0turtle and
julienrbrt
and removed request for
a team
September 13, 2023 12:34
Comment on lines
727
to
+733
} | ||
} | ||
|
||
if err := app.preBlock(); err != nil { | ||
return nil, err | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:660)
20 tasks
mmsqe
reviewed
Sep 13, 2023
julienrbrt
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #17421 done by Mergify.
Cherry-pick of 4eb0185 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com