refactor!: deprecate blocktime on context #17738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
alexanderbez and
atheeshp
and removed request for
a team
alexanderbez
approved these changes
Sep 14, 2023
julienrbrt
reviewed
Sep 14, 2023
julienrbrt
reviewed
Sep 16, 2023
| @@ -106,7 +106,7 @@ func (k msgServer) CreateValidator(ctx context.Context, msg *types.MsgCreateVali | |||
|
|
|||
| commission := types.NewCommissionWithTime( | |||
| msg.Commission.Rate, msg.Commission.MaxRate, | |||
| msg.Commission.MaxChangeRate, sdkCtx.BlockHeader().Time, | |||
| msg.Commission.MaxChangeRate, sdkCtx.HeaderInfo().Time, | |||
There was a problem hiding this comment.
I think for these kind of changes need an UPGRADING.md section (Unreleased > Modules > All)
There was a problem hiding this comment.
this isnt required to be changed as part of this pr. I migrated to be consistent throughout the repo
There was a problem hiding this comment.
You are right, the getter is an alias to the headerinfo, commented before seing it 😅
This does make my other comment even more relevant however.
types/context.go
Outdated
| @@ -175,6 +173,7 @@ func (c Context) WithHeaderHash(hash []byte) Context { | |||
|
|
|||
| // WithBlockTime returns a Context with an updated CometBFT block header time in UTC with no monotonic component. | |||
| // Stripping the monotonic component is for time equality. | |||
| // Deprecated: use WithHeaderInfo instead | |||
| func (c Context) WithBlockTime(newTime time.Time) Context { | |||
There was a problem hiding this comment.
I think we should kill the setter but keep the getters.
Otherwise now, WithBlockTime/BlockTime with behave very weirdly as BlockTime gets is from the header info.
julienrbrt
reviewed
Sep 16, 2023
julienrbrt
approved these changes
Sep 17, 2023
facundomedica
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pulls out some changes from #17502 as the pr was getting big and had more changes to come.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change