fix(baseapp): select txs correctly with no-op mempool #17769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Sep 15, 2023
alexanderbez
commented
Sep 15, 2023
alexanderbez
added
backport/v0.47.x
github-prbot
requested review from
a team,
tac0turtle and
atheeshp
and removed request for
a team
itsdevbear
reviewed
Sep 18, 2023
odeke-em
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Nice work @alexanderbez, just some review comments but mostly LGTM!
…cosmos-sdk into bez/default-prep-prop-size-check
odeke-em
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
LGTM, thank you @alexanderbez, though just one code suggestion wasn't dismissed nor acknowledged.
It was a nitpick -- dismissed 👍 |
…cosmos-sdk into bez/default-prep-prop-size-check
itsdevbear
approved these changes
Sep 21, 2023
julienrbrt
changed the title
…cosmos-sdk into bez/default-prep-prop-size-check
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2023
(cherry picked from commit 63d046d) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2023
(cherry picked from commit 63d046d) # Conflicts: # CHANGELOG.md # baseapp/abci_utils.go # baseapp/abci_utils_test.go # baseapp/baseapp.go
alexanderbez
pushed a commit
that referenced
this pull request
Sep 25, 2023
julienrbrt
pushed a commit
that referenced
this pull request
Sep 25, 2023
… (#17848) Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Oct 9, 2023
…s#17769) (cosmos#17848) Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when an application uses a no-op mempool or no mempool at all, we simply return the txs provided to the app from CometBFT.
However, simply returning the txs is incorrect per the ABCI CometBFT specification as we need to ensure the returned txs meet block size constraints (size and gas).
I've abstracted away this logic into a
TxSelectortype which should make the code easier to readAlso, there was a comparison bug (
<vs<=)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change