feat!: Add start time for continuous vesting accounts #17810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
facundomedica and
samricotta
and removed request for
a team
tac0turtle
reviewed
Sep 19, 2023
tac0turtle
reviewed
Sep 19, 2023
odeke-em
approved these changes
Oct 4, 2023
julienrbrt
reviewed
Oct 5, 2023
| @@ -70,8 +74,12 @@ func (s msgServer) CreateVestingAccount(ctx context.Context, msg *types.MsgCreat | |||
| if msg.Delayed { | |||
| vestingAccount = types.NewDelayedVestingAccountRaw(baseVestingAccount) | |||
| } else { | |||
| sdkctx := sdk.UnwrapSDKContext(ctx) | |||
| vestingAccount = types.NewContinuousVestingAccountRaw(baseVestingAccount, sdkctx.HeaderInfo().Time.Unix()) | |||
| start := msg.StartTime | |||
There was a problem hiding this comment.
Actually, we should add a check that it does not start in the past and that start is a valid time ( >= 0)
Missing the <= 0 check for instance.
There was a problem hiding this comment.
Whats the effect of starting at the past? That instantly a portion will be vested right?
There was a problem hiding this comment.
Probably, but that is a weird use case. Avoiding starting in the past can avoid people making fat-finger mistakes.
alexanderbez
approved these changes
Oct 12, 2023
julienrbrt
reviewed
Oct 16, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
|
@julienrbrt @tac0turtle which Cosmos SDK releases was this included in? I couldn't find it in the changelog. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cherry-pick from celestiaorg#342 based on this comment here #4287 (comment). It allows for a vesting account to start at some future defined start time
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change