chore(nft): remove address.String() calls from nft #17846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Sep 24, 2023
| entries := make([]*nft.Entry, len(accounts)-1) | ||
| for i := 0; i < len(accounts)-1; i++ { | ||
| owner := accounts[i] | ||
| oast, err := ac.BytesToString(owner.Address.Bytes()) |
There was a problem hiding this comment.
I lol-ed at the variable naming.
likhita-809
approved these changes
Sep 25, 2023
samricotta
approved these changes
Sep 25, 2023
|
wold prefer to keep the release version diffs small. this doesnt add much value to the older version, not sure its worth it |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I understand, but this is x/nft, which is a separate go.mod, so this isn't the v0.50 release. |
tac0turtle
added
the
backport/v0.50.x
mergify bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
(cherry picked from commit f9c5fd4) # Conflicts: # x/nft/keeper/nft.go
tac0turtle
added a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #13140
this pr removes .String calls from the nft module.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change