Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/gov): set default constitution in gov migration #17953

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix(x/gov): set default constitution in gov migration #17953

merged 2 commits into from
Oct 6, 2023

Conversation

julienrbrt
Copy link
Member

Description

The constitution isn't set in gov migration, which leads to an issue when exporting genesis after an upgrade.
Thanks @alpe for finding this!

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 4, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner October 4, 2023 09:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@julienrbrt your pull request is missing a changelog!

@tac0turtle tac0turtle added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 45b44e6 Oct 6, 2023
52 checks passed
@tac0turtle tac0turtle deleted the julien/gov-migration branch October 6, 2023 08:18
mergify bot pushed a commit that referenced this pull request Oct 6, 2023
@julienrbrt @mergify
fix(x/gov): set default constitution in gov migration (#17953)
7e65f53 
(cherry picked from commit 45b44e6)

# Conflicts:
#	x/gov/migrations/v5/store.go
@mergify mergify bot mentioned this pull request Oct 6, 2023
Merged
tac0turtle added a commit that referenced this pull request Oct 6, 2023
@mergify @julienrbrt @tac0turtle
fix(x/gov): set default constitution in gov migration (backport #17953)…
a05fc0d 
… (#17983)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:collections C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @tac0turtle