Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment on flag for textual #18040

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: comment on flag for textual #18040

merged 1 commit into from
Oct 10, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner October 10, 2023 12:33
@github-actions github-actions bot added the C:CLI label Oct 10, 2023
@github-actions
Copy link
Contributor

@tac0turtle your pull request is missing a changelog!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 10, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit ea0a9b2 Oct 10, 2023
50 of 51 checks passed
@tac0turtle tac0turtle deleted the marko/signmode_dics branch October 10, 2023 14:19
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
julienrbrt pushed a commit that referenced this pull request Oct 10, 2023
Co-authored-by: Marko <marbar3778@yahoo.com>
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this pull request Oct 13, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants