Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(baseapp): Add Hybrid Protobuf handlers to MsgServiceRouter #18071

Merged
merged 10 commits into from
Oct 12, 2023
Merged

feat(baseapp): Add Hybrid Protobuf handlers to MsgServiceRouter #18071

merged 10 commits into from
Oct 12, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review October 11, 2023 12:19
@testinginprod testinginprod requested a review from a team as a code owner October 11, 2023 12:19
@github-prbot github-prbot requested review from a team, facundomedica and julienrbrt and removed request for a team October 11, 2023 12:19
@github-actions

This comment has been minimized.

Sign in to view
@testinginprod testinginprod added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 5edabb5 Oct 12, 2023
48 of 49 checks passed
@testinginprod testinginprod deleted the tip/msg_router/hybrid_handlers branch October 12, 2023 15:28
@testinginprod
Copy link
Contributor Author

@Mergifyio backport release/v0.50.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 2, 2023
@testinginprod @mergify
feat(baseapp): Add Hybrid Protobuf handlers to MsgServiceRouter (#18071)
f5adc0c 
Co-authored-by: unknown unknown <unknown@unknown>
(cherry picked from commit 5edabb5)

# Conflicts:
#	CHANGELOG.md
#	baseapp/grpcrouter.go
#	baseapp/grpcrouter_test.go
#	baseapp/internal/protocompat/protocompat.go
#	baseapp/msg_service_router.go
@mergify mergify bot mentioned this pull request Nov 2, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Nov 3, 2023
@mergify @testinginprod
feat(baseapp): Add Hybrid Protobuf handlers to MsgServiceRouter (back…
7843204 
…port #18071) (#18338)

Co-authored-by: testinginprod <98415576+testinginprod@users.noreply.github.com>
Co-authored-by: unknown unknown <unknown@unknown>
@testinginprod testinginprod mentioned this pull request Dec 19, 2023
Closed
44 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testinginprod @tac0turtle @julienrbrt