Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add default key name #18101

Merged
merged 12 commits into from
Oct 16, 2023
Merged

feat(client): add default key name #18101

merged 12 commits into from
Oct 16, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #17971

Allow to specify default --from key name in the config.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions

This comment has been minimized.

@julienrbrt julienrbrt requested a review from tac0turtle October 12, 2023 11:29
@tac0turtle tac0turtle added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit bb34c42 Oct 16, 2023
47 of 50 checks passed
@tac0turtle tac0turtle deleted the julien/default-from branch October 16, 2023 11:10
@julienrbrt
Copy link
Member Author

I am going to leave this feature for v0.51 and improve confix to migrate client.toml as well for a better experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Automatically set --from flag if one key in keyring
3 participants