Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/slashing): remove global bech32 usage #18115

Merged
merged 10 commits into from
Oct 17, 2023
Merged

refactor(x/slashing): remove global bech32 usage #18115

merged 10 commits into from
Oct 17, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #13140

This pr removes global usage of bech32 in the slashing module.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner October 13, 2023 11:58
@tac0turtle tac0turtle marked this pull request as draft October 13, 2023 11:58
@github-prbot github-prbot requested review from a team, facundomedica and testinginprod and removed request for a team October 13, 2023 11:58
@julienrbrt julienrbrt changed the title chore: remove global bech32 usage in slashing module refactor(x/slashing): remove global bech32 usage Oct 13, 2023
@tac0turtle tac0turtle marked this pull request as ready for review October 13, 2023 12:55
@github-prbot github-prbot requested a review from a team October 13, 2023 12:58
julienrbrt
julienrbrt reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

x/slashing/types/signing_info.go
@@ -2,17 +2,15 @@ package types

import (
"time"

sdk "github.com/cosmos/cosmos-sdk/types"
)

// NewValidatorSigningInfo creates a new ValidatorSigningInfo instance
func NewValidatorSigningInfo(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API breaking changelog

x/slashing/module.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle force-pushed the marko/slashing_bech32 branch from 4ff67fd to 9c623e0 Compare October 16, 2023 11:18
atheeshp
atheeshp approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

likhita-809
likhita-809 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle tac0turtle enabled auto-merge October 16, 2023 13:48
@tac0turtle tac0turtle added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 93770f5 Oct 17, 2023
50 checks passed
@tac0turtle tac0turtle deleted the marko/slashing_bech32 branch October 17, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@likhita-809 likhita-809 likhita-809 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

Assignees

@atheeshp atheeshp

@likhita-809 likhita-809

Labels
C:Simulations C:x/slashing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tac0turtle @julienrbrt @atheeshp @likhita-809