-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): add missing param to gov readme #18181
Conversation
WalkthroughThe proposed change introduces a new parameter Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- x/gov/README.md (1 hunks)
Additional comments (Suppressed): 1
x/gov/README.md (1)
- 773-773: The addition of the
min_initial_deposit_ratio
parameter to the documentation is a good step towards keeping the documentation up-to-date with the codebase. However, it would be helpful to include a brief description of what this parameter does in the context of the governance module. This would aid developers in understanding its purpose and how to use it effectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
(cherry picked from commit 13adf11)
Description
add missing param to readme
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
min_initial_deposit_ratio
. This feature allows users to adjust the minimum initial deposit ratio, enhancing the flexibility of the governance system. The default value is set at "0.1", providing a sensible starting point for most users.