fix: RelativePow now returns 1 when 0^0 #18211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request addresses two key bug fixes in the Changes
TipsChat with CodeRabbit Bot (
|
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- math/uint.go (1 hunks)
- math/uint_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- math/uint.go
Additional comments (Suppressed): 1
math/uint_test.go (1)
- 274-274: The test case has been updated to reflect the new expected behavior of the
RelativePowfunction when bothxandnare zero. The expected result has been changed fromsdkmath.NewUint(10)tosdkmath.NewUint(1), which is the correct mathematical result for0^0. This change is consistent with the updated implementation of theRelativePowfunction.
facundomedica
added
backport/v0.47.x
|
dont think we can backport this to 0.47 but 0.50 is safe |
julienrbrt
approved these changes
Oct 23, 2023
julienrbrt
removed
the
backport/v0.47.x
tac0turtle
approved these changes
Oct 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
(cherry picked from commit 442c3c5) # Conflicts: # math/CHANGELOG.md # math/uint.go
tac0turtle
added a commit
that referenced
this pull request
Oct 23, 2023
|
I forgot this is math. So this is the same version used in v0.47, v0.50, etc.. this means the backported wasn't necessary and that it will be in v0.47 available. @facundomedica can you check on source graph that no one depends on it? Otherwise I'll check myself once im no more afk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've checked current usages and it doesn't look like there are people misusing this enough to ever get the wrong result. The issue is that when x and n are 0 then the result is whatever being passed as b, even though there's a comment stating
// 0^0 = 1.This is not being used in the SDK btw.
https://github.com/search?q=RelativePow+language%3AGo&type=code&l=Go
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeSummary by CodeRabbit
RelativePowfunction to return 1 when raising 0 to the power of 0, enhancing the mathematical accuracy of the software.ApproxRootfunction's rounding behavior, ensuring consistent and expected results across all calculations.These changes improve the reliability of mathematical operations within the software, providing users with more accurate and predictable results.