-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mint): new go module #18283
Conversation
WalkthroughThe changes primarily involve the migration of the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (21)
- client/v2/go.mod
- go.mod
- simapp/go.mod
- tests/go.mod
- tests/starship/tests/go.mod
- x/authz/go.mod
- x/bank/go.mod
- x/circuit/go.mod
- x/distribution/go.mod
- x/evidence/go.mod
- x/feegrant/go.mod
- x/gov/go.mod
- x/group/go.mod
- x/mint/go.mod
- x/mint/go.sum
- x/nft/go.mod
- x/params/go.mod
- x/protocolpool/go.mod
- x/slashing/go.mod
- x/staking/go.mod
- x/upgrade/go.mod
Files selected for processing (57)
- .github/workflows/test.yml (1} hunks)
- CHANGELOG.md (1} hunks)
- UPGRADING.md (1} hunks)
- baseapp/block_gas_test.go (2} hunks)
- baseapp/utils_test.go (2} hunks)
- contrib/images/simd-env/Dockerfile (1} hunks)
- proto/cosmos/mint/module/v1/module.proto (1} hunks)
- proto/cosmos/mint/v1beta1/genesis.proto (1} hunks)
- proto/cosmos/mint/v1beta1/mint.proto (1} hunks)
- proto/cosmos/mint/v1beta1/query.proto (1} hunks)
- proto/cosmos/mint/v1beta1/tx.proto (1} hunks)
- simapp/app.go (2} hunks)
- simapp/app_config.go (2} hunks)
- simapp/app_test.go (2} hunks)
- simapp/app_v2.go (2} hunks)
- simapp/simd/cmd/testnet_test.go (2} hunks)
- simapp/test_helpers.go (2} hunks)
- tests/e2e/mint/grpc.go (1} hunks)
- tests/e2e/mint/suite.go (1} hunks)
- tests/integration/bank/keeper/deterministic_test.go (2} hunks)
- tests/integration/evidence/keeper/infraction_test.go (2} hunks)
- tests/integration/gov/keeper/keeper_test.go (2} hunks)
- tests/integration/gov/module_test.go (1} hunks)
- tests/integration/rapidgen/rapidgen.go (2} hunks)
- tests/integration/slashing/keeper/keeper_test.go (2} hunks)
- tests/integration/staking/keeper/common_test.go (2} hunks)
- tests/integration/staking/keeper/deterministic_test.go (2} hunks)
- tests/integration/staking/simulation/operations_test.go (2} hunks)
- tests/integration/tx/aminojson/aminojson_test.go (2} hunks)
- tests/integration/tx/decode_test.go (2} hunks)
- testutil/configurator/configurator.go (1} hunks)
- testutil/integration/example_test.go (2} hunks)
- testutil/sims/address_helpers.go (1} hunks)
- x/authz/testutil/app_config.go (1} hunks)
- x/distribution/client/cli/tx_test.go (2} hunks)
- x/distribution/testutil/app_config.go (2} hunks)
- x/feegrant/simulation/operations_test.go (2} hunks)
- x/group/keeper/keeper_test.go (2} hunks)
- x/group/keeper/msg_server_test.go (1} hunks)
- x/group/testutil/app_config.go (1} hunks)
- x/mint/CHANGELOG.md (1} hunks)
- x/mint/abci.go (1} hunks)
- x/mint/keeper/genesis.go (1} hunks)
- x/mint/keeper/genesis_test.go (1} hunks)
- x/mint/keeper/grpc_query.go (1} hunks)
- x/mint/keeper/grpc_query_test.go (1} hunks)
- x/mint/keeper/keeper.go (1} hunks)
- x/mint/keeper/keeper_test.go (1} hunks)
- x/mint/keeper/msg_server.go (1} hunks)
- x/mint/keeper/msg_server_test.go (1} hunks)
- x/mint/module.go (1} hunks)
- x/mint/module_test.go (1} hunks)
- x/mint/simulation/genesis.go (1} hunks)
- x/mint/simulation/genesis_test.go (1} hunks)
- x/mint/simulation/proposals.go (1} hunks)
- x/mint/simulation/proposals_test.go (1} hunks)
- x/mint/sonar-project.properties (1} hunks)
Files not processed due to max files limit (6)
- x/mint/testutil/app_config.go
- x/nft/testutil/app_config.go
- x/protocolpool/testutil/app_config.go
- x/slashing/simulation/operations_test.go
- x/slashing/testutil/app_config.go
- x/staking/testutil/app_config.go
Files skipped from review due to trivial changes (52)
- .github/workflows/test.yml
- CHANGELOG.md
- UPGRADING.md
- baseapp/block_gas_test.go
- baseapp/utils_test.go
- proto/cosmos/mint/module/v1/module.proto
- proto/cosmos/mint/v1beta1/genesis.proto
- proto/cosmos/mint/v1beta1/mint.proto
- proto/cosmos/mint/v1beta1/query.proto
- proto/cosmos/mint/v1beta1/tx.proto
- simapp/app.go
- simapp/app_v2.go
- simapp/simd/cmd/testnet_test.go
- simapp/test_helpers.go
- tests/e2e/mint/grpc.go
- tests/e2e/mint/suite.go
- tests/integration/bank/keeper/deterministic_test.go
- tests/integration/evidence/keeper/infraction_test.go
- tests/integration/gov/keeper/keeper_test.go
- tests/integration/gov/module_test.go
- tests/integration/rapidgen/rapidgen.go
- tests/integration/slashing/keeper/keeper_test.go
- tests/integration/staking/keeper/common_test.go
- tests/integration/staking/keeper/deterministic_test.go
- tests/integration/staking/simulation/operations_test.go
- tests/integration/tx/aminojson/aminojson_test.go
- tests/integration/tx/decode_test.go
- testutil/configurator/configurator.go
- testutil/integration/example_test.go
- testutil/sims/address_helpers.go
- x/authz/testutil/app_config.go
- x/distribution/client/cli/tx_test.go
- x/feegrant/simulation/operations_test.go
- x/group/keeper/keeper_test.go
- x/group/keeper/msg_server_test.go
- x/group/testutil/app_config.go
- x/mint/CHANGELOG.md
- x/mint/abci.go
- x/mint/keeper/genesis.go
- x/mint/keeper/genesis_test.go
- x/mint/keeper/grpc_query.go
- x/mint/keeper/grpc_query_test.go
- x/mint/keeper/keeper.go
- x/mint/keeper/keeper_test.go
- x/mint/keeper/msg_server.go
- x/mint/keeper/msg_server_test.go
- x/mint/module.go
- x/mint/module_test.go
- x/mint/simulation/genesis.go
- x/mint/simulation/genesis_test.go
- x/mint/simulation/proposals_test.go
- x/mint/sonar-project.properties
Additional comments: 8
x/mint/simulation/proposals.go (1)
- 7-7: The import path for the
mint
module has been updated fromgit.luolix.top/cosmos/cosmos-sdk/x/mint/types
tocosmossdk.io/x/mint/types
. Ensure that the new import path is correct and the module is available at the new location.contrib/images/simd-env/Dockerfile (1)
- 23-23: The addition of the
mint
module'sgo.mod
andgo.sum
files to the Dockerfile is consistent with the changes described in the PR summary. This ensures that themint
module's dependencies are downloaded and available in the Docker image.x/distribution/testutil/app_config.go (2)
6-6: The import path for the
mint
module has been updated fromgit.luolix.top/cosmos/cosmos-sdk/x/mint
tocosmossdk.io/x/mint
. Ensure that the new import path is correctly configured and accessible. Also, verify that all references to themint
module in the codebase have been updated to use the new import path.12-15: The import statement for the
mint
module has been removed from this section. This change is consistent with the update in the import path for themint
module.simapp/app_test.go (2)
27-27: The import path for the
mint
module has been updated fromgit.luolix.top/cosmos/cosmos-sdk/x/mint
tocosmossdk.io/x/mint
. Ensure that all references to themint
module in the codebase have been updated to use the new import path.41-44: The import statement for the
mint
module has been removed from this section. This change is consistent with the update to the import path for themint
module.simapp/app_config.go (2)
49-50: The import path for the
mint
module has been updated fromgit.luolix.top/cosmos/cosmos-sdk/x/mint
tocosmossdk.io/x/mint
. Ensure that the new import path is correct and accessible. Also, verify that the side-effects caused by this import are still valid and necessary in the new context.71-74: The old import statements for the
mint
module have been removed. This is consistent with the change in the import path for themint
module. Ensure that there are no remaining references to the old import path in the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't expect mint to be imported in the SDK in tests. The dep cleaning is going to be something 😅
Description
Closes: #17813
ref #11899
spinout mint to its own go module
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit