Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sim): set FlagSigverifyTxValue to newApp for TestAppSimulationAfterImport #18289

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

luchenqun
Copy link
Contributor

@luchenqun luchenqun commented Oct 28, 2023

Description

In #17911, I added a new SigverifyTx flag whether to verify the signature of the transaction. But I forgot that TestAppSimulationAfterImport passed this flag to the newApp of this test. Now just add the relevant logic.

Summary by CodeRabbit

  • Test Improvement: Enhanced the TestAppSimulationAfterImport function to handle a new scenario. This update allows the simulation test to bypass transaction signature verification when the FlagSigverifyTxValue flag is set to false. This change improves the flexibility of our testing environment and ensures more robust application testing.

@luchenqun luchenqun requested a review from a team as a code owner October 28, 2023 14:42
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2023

Walkthrough

The update introduces a conditional check in the TestAppSimulationAfterImport function of the sim_test.go file. This change ensures that the newApp instance skips signature verification on transactions when the FlagSigverifyTxValue flag is set to false.

Changes

File Summary
simapp/.../sim_test.go A new condition is added to the TestAppSimulationAfterImport function. If FlagSigverifyTxValue is false, SetNotSigverifyTx is called on newApp, skipping signature verification on transactions.

🐇💻

"In the land of code, where logic is king,

Changes are made, new features they bring.

A flag now decides, to verify or not,

A rabbit's touch, in the code plot.

Celebrate the change, for it's not in vain,

In the world of code, it's another gain!" 🎉🥕


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7bef022 and fc14eda.
Files selected for processing (1)
  • simapp/sim_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • simapp/sim_test.go

@tac0turtle tac0turtle added this pull request to the merge queue Oct 30, 2023
Merged via the queue into cosmos:main with commit 0e94d74 Oct 30, 2023
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants