Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docs script #18491

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: fix docs script #18491

merged 1 commit into from
Nov 16, 2023

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Nov 16, 2023

Description

merged the last pr to fast, this fixes the issue, tested a few times locally


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Documentation

    • Updated the pull request checklist to include running lint and test commands.
    • Revised the Dependabot configuration to adjust update schedules and add a new task for release branches.
    • Removed specific "Rosetta" references from the PR labeler configuration.
  • CI/CD Pipeline

    • Updated Go version from 1.20 to 1.21 in various GitHub Actions workflows.
    • Removed the "Build Rosetta" step from the build workflow.
    • Changed the Markdown link checker trigger to pull requests and added pre/post link check scripts.
    • Adjusted the severity level for failing on dependency review from "moderate" to "high".
    • Added new steps for running linting conditionally based on file changes.
  • Dependencies

    • Removed scheduled tasks for specific directories in Dependabot configuration.
  • Build System

    • Updated the base Docker image to golang:1.21-alpine and added additional dependencies.
    • Removed rosetta related targets from the Makefile and updated the protoVer variable.
  • Release Process

    • Provided guidelines for managing Cosmos SDK modules and their release processes.
  • API Changes

    • Renamed request and response types in various API files.
    • Added new fields and deprecated old types in protocol buffer definitions.
    • Updated comments and field names for clarity in API definitions.
  • Core Application

    • Introduced changes to support ABCI 2.0 integration and optimistic execution.
    • Added new interfaces and methods related to transaction selection and block proposal handling.
    • Updated error handling and gas metering in tests and core application logic.
  • Miscellaneous

    • Updated the recommended Go version in the README to the latest maintained version.
    • Increased test timeout settings and adjusted linter configurations in .golangci.yml.

@tac0turtle tac0turtle requested review from julienrbrt and a team as code owners November 16, 2023 16:44
@tac0turtle tac0turtle changed the base branch from main to release/v0.50.x November 16, 2023 16:44
Copy link
Contributor

coderabbitai bot commented Nov 16, 2023

Walkthrough

Walkthrough

The changes across various files in the repository reflect updates to Go version from 1.20 to 1.21, removal of Rosetta-related components, and updates to GitHub Actions workflows. There are also significant updates to the Cosmos SDK, including deprecations, new features, and renaming of types and fields in protocol buffer files. Additionally, there are updates to the baseapp package to handle new features like optimistic execution and changes to error handling and testing in various test suites.

Changes

File Path Change Summary
.github/... Updated Go version to 1.21, modified GitHub Actions workflows, and removed Rosetta-related components.
.golangci.yml Increased test timeout, added exclusion patterns, and modified linter settings.
Dockerfile Updated base image to golang:1.21-alpine and added new dependencies.
Makefile Removed Rosetta targets and updated protoVer.
README.md Updated Go version recommendation to the latest maintained version.
RELEASE_NOTES.md Detailed new features and improvements in Cosmos SDK v0.50.1.
RELEASE_PROCESS.md Outlined release processes for Cosmos SDK modules.
api/cosmos/... Renamed types, added new fields, deprecated types, and updated comments in protocol buffer files.
baseapp/... Added new features like optimistic execution, updated error handling, and added new test functions.
baseapp/block_gas_test.go Modified gas consumption calculations and transaction handling in tests.

Please note that the ellipsis (...) in the file path column is used to indicate that multiple files in the directory or subdirectories have similar changes and are grouped together for brevity.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@tac0turtle tac0turtle merged commit d367589 into release/v0.50.x Nov 16, 2023
8 checks passed
@tac0turtle tac0turtle deleted the marko/fix_script branch November 16, 2023 20:03
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants