fix(x/auth): Add fees on batch sign (backport #18564) #18592
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 7bdbc46) # Conflicts: # tests/e2e/auth/suite.go # x/auth/CHANGELOG.md # x/auth/client/cli/tx_sign.go
|
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
|
@raynaudoe are you up to fix the conflicts here please :) |
| @@ -52,6 +52,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * (x/auth) [#18564](https://github.com/cosmos/cosmos-sdk/pull/18564) Fix total fees calculation when batch signing. | |||
There was a problem hiding this comment.
Note for myself, search in the whole main repo for issue number when changelog merging after tag of a patch release, given that a changelog can be under all submodules from now on main.
x/auth/client/testutil/helpers.go
Outdated
| filename, | ||
| } | ||
|
|
||
| func TxSignBatchExec(clientCtx client.Context, from fmt.Stringer, filenames []string, extraArgs ...string) (testutil.BufferWriter, error) { |
There was a problem hiding this comment.
We cannot introduce a breaking change in patch release, so let's revert this here and on main (as the breaking change wasn't necessary at the first place).
For the test case, we can just use clitestutil.ExecTestCLICmd directly and leave the API unchanged for the others.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Should I commit the fix directly on this branch ? |
Yes, you can push directly here. |
Fix suite_test.go
Done! |
There was a problem hiding this comment.
lgtm!
@raynaudoe are you up as well to remove the API break from main as well as you did here?
yeah sure! I'll do a PR today |
|
This is an automatic backport of pull request #18564 done by Mergify.
Cherry-pick of 7bdbc46 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com