Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client/v2/offchain): sign and verify file #18626
feat(client/v2/offchain): sign and verify file #18626
Changes from 35 commits
b024711
bec788d
bfa6ec4
b3743b8
55c5a98
c640e72
4742f2a
73becd5
08f459a
22866b6
029bcc2
d69a083
f0289a5
da2ef9e
8af522f
edeb06b
3d06698
fa7fe5b
61db866
ea790a7
9f33e10
5654037
2581564
4010f9f
7d0db42
ef60b05
520f720
92cf87b
19ba61f
3e1daa3
c92ebc5
3c8c664
35c2a30
e7a8fa8
6e78084
5494a37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
data
field is still astring
. If binary data support is required, consider changing this field tobytes
to handle binary data more effectively.Committable suggestion