Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client/keys): add --yes option to keys export and keys mnemonic #18745

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

levisyin
Copy link
Contributor

Description

Adding --yes option to <appd> keys export and <appd> keys mnemonic , so that we can skip interactive confirmation in script.

@levisyin levisyin requested a review from a team as a code owner December 14, 2023 05:53
Copy link
Contributor

coderabbitai bot commented Dec 14, 2023

Walkthrough

The recent update introduces a --yes option to the keys export and keys mnemonic commands in a certain application, allowing users to bypass interactive confirmation prompts. This enhancement is aimed at streamlining the user experience for those who prefer non-interactive or automated workflows. The implementation includes modifications to the command flags and logic, as well as the addition of test cases to ensure the new feature works as expected.

Changes

File(s) Change Summary
client/keys/export.go Added a flagYes to command flags for skipping confirmation prompts. Modified logic to respect the --yes option.
client/keys/mnemonic.go Added a flagYes to command flags for skipping confirmation prompts. Modified logic to respect the --yes option.
client/keys/export_test.go Introduced new test case to validate the --yes option functionality, ensuring non-interactive command execution.
client/keys/mnemonic_test.go Introduced new test case to validate the --yes option functionality, ensuring non-interactive command execution.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Dec 14, 2023
client/keys/mnemonic.go Show resolved Hide resolved
client/keys/mnemonic_test.go Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK!

CHANGELOG.md Show resolved Hide resolved
auto-merge was automatically disabled December 15, 2023 11:42

Head branch was pushed to by a user without write access

@julienrbrt julienrbrt added this pull request to the merge queue Dec 15, 2023
Merged via the queue into cosmos:main with commit 0268ff9 Dec 15, 2023
54 of 56 checks passed
@levisyin levisyin deleted the feat/add-yes-to-skip branch December 15, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants