-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testutil): fix FreeTCPAddr localhost usage #18996
Conversation
WalkthroughThe change involves updating the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
I don't think additional testing is relevant, nor would I be sure how to make a CI test for one of those environments. That being said, I have tested these changes in WSL, which is such a system, and it now works instead of panicking :). I could attach a before and after screenshot if desired. As far as the entry changelog, I could write something similar, but shorter, for the changelog if desired. Or is this a simple enough PR that this doesn't require that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
(cherry picked from commit 78ce70d)
Description
Closes: #18992
Makes the change in the
FreeTCPAddr
to check if the port is free on127.0.0.1
sincelocalhost
is not always equal to that IP as a standard.Should not affect any systems where
localhost
is equal to that IP. Would only fix it for systems where that is not the case.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...