-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(changelog): move changelog items to respective location #19001
Conversation
f8f9e1c
to
a723e71
Compare
WalkthroughThe recent updates to the codebase involve substantial enhancements and API-breaking changes across various modules. Key changes include the introduction of new features such as multiple transaction broadcasting, new message types, and improved error handling. Deprecated functions have been removed, and gas efficiency has been optimized. Additionally, there have been shifts towards using collections, modifications to state management, and adjustments for IBC compatibility, all indicative of a move towards more modular and robust architecture. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that one question is fine then then all good
Every Module contains its own CHANGELOG.md. Please refer to the module you are interested in. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that all module-specific CHANGELOG.md files are updated accordingly with the changes mentioned here to maintain consistency across documentation.
* (staking) [#18506](https://github.com/cosmos/cosmos-sdk/pull/18506) Detect the length of the ed25519 pubkey in CreateValidator to prevent panic. | ||
* (tx) [#18772](https://github.com/cosmos/cosmos-sdk/pull/18772) Remove misleading gas wanted from tx simulation failure log. | ||
* (tx) [#18852](https://github.com/cosmos/cosmos-sdk/pull/18852) Add `WithFromName` to tx factory. | ||
* (client/tx) [#18852](https://github.com/cosmos/cosmos-sdk/pull/18852) Add `WithFromName` to tx factory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shell script did not find any references to appd export
in UPGRADING.md
. This suggests that the CLI breaking change regarding appd export
is not documented in UPGRADING.md
as the review comment suggested it should be. Ensure that users are aware of the new command to use.
Description
This pr moves items from the root level changelog to the modules changelog to better identify breaking items for modules
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...