Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy correct go.mod into container #19008

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: copy correct go.mod into container #19008

merged 2 commits into from
Jan 10, 2024

Conversation

tac0turtle
Copy link
Member

Description

Closes: #19006

fix docker image, i made a mistake and was copying the wrong go.mod


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@tac0turtle tac0turtle marked this pull request as ready for review January 10, 2024 15:01
@tac0turtle tac0turtle requested a review from a team as a code owner January 10, 2024 15:01
Copy link
Contributor

coderabbitai bot commented Jan 10, 2024

Walkthrough

The Dockerfile has been updated to address a build failure in the make localnet-debug process. The amendment involves replacing the store module with the depinject module and ensuring the inclusion of go.mod and go.sum files for specific modules. This change aims to resolve the build issues while complying with the Cosmos SDK's main version requirements.

Changes

File Changed Change Summary
.../simd-env/Dockerfile Replaced COPY instruction for store module with depinject module.

Assessment against linked issues

Objective Addressed Explanation
Identify and resolve the error causing the failure of make localnet-debug when building the image (#19006)
Address the missing go.mod file for cosmossdk.io/depinject@v1.0.0-alpha.4 (#19006)
Ensure Dockerfile includes steps to copy go.mod and go.sum for store, x/auth, x/bank, x/staking (#19006) It's clear that the depinject module has been addressed, but it is not specified if the go.mod and go.sum for all listed modules are included.
Verify changes align with Cosmos SDK main version and introduce no new issues (#19006) Without access to the full Dockerfile and the context of the Cosmos SDK main version, it's unclear if all requirements are met and no new issues are introduced.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tac0turtle tac0turtle changed the title fix: docker image fix: copy correct go.mod into container Jan 10, 2024
@alexanderbez alexanderbez added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 1aaad3e Jan 10, 2024
51 of 52 checks passed
@alexanderbez alexanderbez deleted the marko/19006 branch January 10, 2024 16:53
relyt29 pushed a commit to relyt29/cosmos-sdk that referenced this pull request Jan 22, 2024
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: localnet-debug fails when building image
4 participants