Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orm): run module_test failed #19057

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

levisyin
Copy link
Contributor

@levisyin levisyin commented Jan 15, 2024

Description

Refer to #19040

PR #19040 removed some imports and caused the test failed to run


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@levisyin levisyin requested a review from a team as a code owner January 15, 2024 08:00
Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Walkthrough

The update in the codebase includes the integration of a new package and a refactor of variable names within a test module. The import of "appv1alpha1" suggests the introduction or use of a new set of definitions or API versions, while the renaming of "am" to "appconfig" reflects a clarification in naming, likely for better readability or to align with naming conventions elsewhere in the codebase.

Changes

File Path Change Summary
orm/model/ormdb/module_test.go Introduced import of "appv1alpha1" package; renamed "am" to "appconfig" in module registration.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the C:orm label Jan 15, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should make the test-orm job required, as CI caught it that, but I've missed it. (https://github.com/cosmos/cosmos-sdk/actions/runs/7514719218/job/20457901400).
EDIT: I remember why we didn't make it required: https://github.com/cosmos/cosmos-sdk/actions/runs/7525904160/job/20483066966?pr=19057 / #16655 😅

@levisyin
Copy link
Contributor Author

Thanks!

We should make the test-orm job required, as CI caught it that, but I've missed it. (https://github.com/cosmos/cosmos-sdk/actions/runs/7514719218/job/20457901400). EDIT: I remember why we didn't make it required: https://github.com/cosmos/cosmos-sdk/actions/runs/7525904160/job/20483066966?pr=19057 / #16655 😅

Aha, test-orm failed again😀

@tac0turtle tac0turtle added this pull request to the merge queue Jan 15, 2024
Merged via the queue into cosmos:main with commit 22683c5 Jan 15, 2024
60 of 63 checks passed
@levisyin levisyin deleted the fix/orm-ormdb-test branch January 15, 2024 08:44
relyt29 pushed a commit to relyt29/cosmos-sdk that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants