-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(orm): run module_test failed #19057
Conversation
WalkthroughThe update in the codebase includes the integration of a new package and a refactor of variable names within a test module. The import of "appv1alpha1" suggests the introduction or use of a new set of definitions or API versions, while the renaming of "am" to "appconfig" reflects a clarification in naming, likely for better readability or to align with naming conventions elsewhere in the codebase. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We should make the test-orm
job required, as CI caught it that, but I've missed it. (https://github.com/cosmos/cosmos-sdk/actions/runs/7514719218/job/20457901400).
EDIT: I remember why we didn't make it required: https://github.com/cosmos/cosmos-sdk/actions/runs/7525904160/job/20483066966?pr=19057 / #16655 😅
Aha, |
Description
Refer to #19040
PR #19040 removed some imports and caused the test failed to run
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...