Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simapp): add epoch store to upgrade #20007

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix(simapp): add epoch store to upgrade #20007

merged 1 commit into from
Apr 11, 2024

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Apr 11, 2024 •
edited by coderabbitai bot
Loading

Description

Epoch store type is missing in the upgrade.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • [ ]~~ updated the relevant documentation or specification, including comments for documenting Go code~~
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Integrated epoch functionality into the upgrade process for improved performance handling.

@alpe alpe requested a review from a team as a code owner April 11, 2024 08:05
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent update involves integrating epochstypes into the upgrade handling of the application. This change is primarily focused on enhancing the upgrade process by incorporating new functionalities associated with epochs, ensuring that epoch-related data is properly managed during software upgrades.

Changes

File Path Change Summary
simapp/upgrades.go Added import of epochstypes and included its StoreKey in the RegisterUpgradeHandlers function to manage epoch-related data during upgrades.
Recent Review Details

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between c56152d and 5fb7142.
Files selected for processing (1)
  • simapp/upgrades.go (2 hunks)
Additional Context Used
Path-based Instructions (1)
simapp/upgrades.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (2)
simapp/upgrades.go (2)

8-8: The import of epochstypes is correctly placed and follows the convention of grouping similar types of imports together. This is in line with the Uber Golang style guide.

41-41: The addition of epochstypes.StoreKey to the storeUpgrades struct is appropriate and necessary for ensuring that epoch data is handled during the upgrade process. This change aligns with the described functionality in the PR objectives and the AI-generated summary.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

@alpe your pull request is missing a changelog!

@julienrbrt julienrbrt changed the title fix(upgrade): add epoch store to upgrade fix(simapp): add epoch store to upgrade Apr 11, 2024
@tac0turtle tac0turtle enabled auto-merge April 11, 2024 08:12
@tac0turtle tac0turtle added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 2af3cf2 Apr 11, 2024
65 checks passed
@tac0turtle tac0turtle deleted the alex/fix_upgrades branch April 11, 2024 08:17
alpe added a commit to alpe/cosmos-sdk that referenced this pull request Apr 15, 2024
@alpe
Merge branch 'main' into alex/testnet
183e1ee 
* main: (25 commits)
  fix: Implement gogoproto customtype to secp256r1 keys (cosmos#20027)
  fix(x/epochs): avoid invalid epoch duration in simulation (cosmos#20030)
  fix(x/bank): align query with multi denoms for send-enabled (cosmos#20028)
  refactor(x/slashing)!: remove Accounts String (cosmos#20026)
  refactor(x/evidence)!: remove Address.String() (cosmos#20016)
  chore: make telemetry consistent (cosmos#20025)
  chore: prepare x/tx changelog (cosmos#20015)
  build(deps): Bump actions/add-to-project from 1.0.0 to 1.0.1 (cosmos#20018)
  feat(x/bank): support depinject for send restrictions (cosmos#20014)
  feat: Conditionally emit metrics based on enablement (cosmos#19903)
  fix(store): fix the typo (cosmos#20011)
  docs(x/feegrant): fix allowance typo (cosmos#20000)
  chore(confix): update latest config value (cosmos#20012)
  refactor(x/auth): auth module can recognize x/accounts account (cosmos#20002)
  fix(mempool): use no-op mempool as default (cosmos#19970)
  fix(simapp): add epoch store to upgrade (cosmos#20007)
  test(kv): add unit tests for the helpers functions kv.AssertKeyAtLeas… (cosmos#19965)
  feat(x/tx): Rename custom Amino JSON encoder to "inline_json" (cosmos#19919)
  refactor(x/auth): use transaction service (cosmos#19967)
  fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (cosmos#19976)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alpe @julienrbrt @sontrinh16 @tac0turtle