R4R: Fix stake CLI cmds #2025
Closed
R4R: Fix stake CLI cmds #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added tests for Delegator Validators routes * Updated tests for undelegations * Updated Gaia-lite docs * Updated PENDING.md * Updated comments * Deleted more comments * Add spacing
If dep already sees its scratch directory (.vendor-new), dep ensure fails. This rm -rf's that directory so make get_vendor_deps doesn't fail.
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## release/v0.24.0 #2025 +/- ##
================================================
Coverage 64.86% 64.86%
================================================
Files 115 115
Lines 6862 6862
================================================
Hits 4451 4451
Misses 2127 2127
Partials 284 284 |
alexanderbez
previously requested changes
Aug 14, 2018
PENDING.md
Outdated
| @@ -54,6 +54,7 @@ FEATURES | |||
| * [store] Add transient store | |||
| * [gov] Add slashing for validators who do not vote on a proposal | |||
| * [cli] added `gov query-proposals` command to CLI. Can filter by `depositer`, `voter`, and `status` | |||
| * Added staking query cli cmds for unbonding-delegations and redelegations | |||
There was a problem hiding this comment.
Should we really adding this under the top line? Should be it's separate entry with the referenced PR (or issue -- we need to come to a consensus on that).
There was a problem hiding this comment.
Idk, I was just following the examples from above, but I'll change if you think it's better that way
|
@fedekunze Let's get this in 0.24 - can you rebase and change the base branch? |
* Added tests for Delegator Validators routes * Updated tests for undelegations * Updated Gaia-lite docs * Updated PENDING.md * Updated comments * Deleted more comments * Add spacing
|
I think you still have unintended commits in this PR @fedekunze |
|
Moved to #2043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2021
Also noted that unbonding commands where not included in
cmd/gaia/cmd/gaiacliso I added those as well.Most of the query cmds for staking are not included in the
docs. Will include those in a separate issue (#2026).docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: