refactor(accounts): move multisig into its own go.mod #20928
Conversation
WalkthroughWalkthroughThe changes introduce a new Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (5)
- simapp/go.mod (2 hunks)
- simapp/v2/go.mod (2 hunks)
- tests/go.mod (2 hunks)
- x/accounts/go.mod (3 hunks)
- x/group/go.mod (2 hunks)
Files skipped from review due to trivial changes (2)
- simapp/go.mod
- tests/go.mod
Additional comments not posted (6)
x/accounts/go.mod (2)
11-11: Update placeholder version forcosmossdk.io/x/accounts/defaults/multisig.The version
v0.0.0-00010101000000-000000000000is a placeholder and should be updated to a valid version before release.
189-189: LGTM!The replace directive for
cosmossdk.io/x/accounts/defaults/multisigcorrectly points to./defaults/multisig.x/group/go.mod (2)
48-48: Update placeholder version forcosmossdk.io/x/accounts/defaults/multisig.The version
v0.0.0-00010101000000-000000000000is a placeholder and should be updated to a valid version before release.
194-194: LGTM!The replace directive for
cosmossdk.io/x/accounts/defaults/multisigcorrectly points to../accounts/defaults/multisig.simapp/v2/go.mod (2)
70-70: Update placeholder version forcosmossdk.io/x/accounts/defaults/multisig.The version
v0.0.0-00010101000000-000000000000is a placeholder and should be updated to a valid version before release.
259-259: LGTM!The replace directive for
cosmossdk.io/x/accounts/defaults/multisigcorrectly points to../../x/accounts/defaults/multisig.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
x/accounts/defaults/multisig/go.sumis excluded by!**/*.sum
Files selected for processing (6)
- simapp/go.mod (2 hunks)
- simapp/v2/go.mod (2 hunks)
- tests/go.mod (2 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (3 hunks)
- x/group/go.mod (2 hunks)
Files skipped from review as they are similar to previous changes (5)
- simapp/go.mod
- simapp/v2/go.mod
- tests/go.mod
- x/accounts/go.mod
- x/group/go.mod
Additional comments not posted (4)
x/accounts/defaults/multisig/go.mod (4)
1-3: Module declaration looks good.The module name and Go version are appropriately specified.
5-16: Required dependencies are specified correctly.The dependencies are listed with appropriate versions. Ensure that the versions are consistent with the rest of the codebase.
Verification successful
Required dependencies are specified correctly.
The dependencies listed in
x/accounts/defaults/multisig/go.modare consistent with the versions found in othergo.modfiles across the codebase.
cosmossdk.io/collections v0.4.0cosmossdk.io/core v0.12.1-0.20231114100755-569e3ff6a0d7cosmossdk.io/math v1.3.0cosmossdk.io/x/accounts v0.0.0-00010101000000-000000000000cosmossdk.io/x/bank v0.0.0-20240226161501-23359a0b6d91git.luolix.top/cosmos/cosmos-proto v1.0.0-beta.5git.luolix.top/cosmos/cosmos-sdk v0.51.0git.luolix.top/cosmos/gogoproto v1.5.0git.luolix.top/stretchr/testify v1.9.0google.golang.org/protobuf v1.34.2Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of listed dependencies across the codebase. # Test: Search for dependency versions in go.mod files. Expect: Consistent versions. rg --type go.mod -A 5 $'require ('Length of output: 104
Script:
#!/bin/bash # Description: Verify the consistency of listed dependencies across the codebase. # Test: Search for dependency versions in go.mod files. Expect: Consistent versions. rg --type go.mod -A 10 '^require \('Length of output: 69
Script:
#!/bin/bash # Description: Verify the consistency of listed dependencies across the codebase. # Test: Search for dependency versions in go.mod files. Expect: Consistent versions. rg -t go -g 'go.mod' -A 10 '^require \('Length of output: 68044
173-191: Replacement directives look good.The replacement directives are specified with appropriate paths. Ensure that the paths are correct and consistent with the rest of the codebase.
18-171: Indirect dependencies are specified correctly.The indirect dependencies are listed with appropriate versions. Ensure that the versions are consistent with the rest of the codebase.
Verification successful
Indirect dependencies are specified correctly.
The versions of indirect dependencies in the file
x/accounts/defaults/multisig/go.modare consistent with the versions found in othergo.modfiles across the codebase.
buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.34.2-20240701160653-fedbb9acfd2f.2buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.34.2-20240130113600-88ef6483f90f.2cosmossdk.io/api v0.7.5cosmossdk.io/core/testing v0.0.0-00010101000000-000000000000cosmossdk.io/depinject v1.0.0-alpha.4cosmossdk.io/errors v1.0.1cosmossdk.io/log v1.3.1cosmossdk.io/schema v0.1.1cosmossdk.io/store v1.1.1-0.20240418092142-896cdf1971bccosmossdk.io/x/auth v0.0.0-00010101000000-000000000000cosmossdk.io/x/consensus v0.0.0-00010101000000-000000000000cosmossdk.io/x/staking v0.0.0-00010101000000-000000000000cosmossdk.io/x/tx v0.13.3filippo.io/edwards25519 v1.1.0git.luolix.top/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4git.luolix.top/99designs/keyring v1.2.2git.luolix.top/DataDog/datadog-go v4.8.3+incompatiblegit.luolix.top/DataDog/zstd v1.5.5git.luolix.top/Microsoft/go-winio v0.6.1git.luolix.top/beorn7/perks v1.0.1git.luolix.top/bgentry/speakeasy v0.2.0git.luolix.top/btcsuite/btcd/btcec/v2 v2.3.3git.luolix.top/cespare/xxhash/v2 v2.3.0git.luolix.top/cockroachdb/errors v1.11.1git.luolix.top/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20bgit.luolix.top/cockroachdb/pebble v1.1.0git.luolix.top/cockroachdb/redact v1.1.5git.luolix.top/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06git.luolix.top/cometbft/cometbft v1.0.0-rc1git.luolix.top/cometbft/cometbft-db v0.12.0git.luolix.top/cometbft/cometbft/api v1.0.0-rc.1git.luolix.top/cosmos/btcutil v1.0.5git.luolix.top/cosmos/cosmos-db v1.0.2git.luolix.top/cosmos/crypto v0.1.1git.luolix.top/cosmos/go-bip39 v1.0.0git.luolix.top/cosmos/gogogateway v1.2.0git.luolix.top/cosmos/iavl v1.2.0git.luolix.top/cosmos/ics23/go v0.10.0git.luolix.top/cosmos/ledger-cosmos-go v0.13.3git.luolix.top/danieljoos/wincred v1.2.1git.luolix.top/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33ccgit.luolix.top/decred/dcrd/dcrec/secp256k1/v4 v4.3.0git.luolix.top/dgraph-io/badger/v4 v4.2.0git.luolix.top/dgraph-io/ristretto v0.1.1git.luolix.top/dustin/go-humanize v1.0.1git.luolix.top/dvsekhvalnov/jose2go v1.6.0git.luolix.top/emicklei/dot v1.6.2git.luolix.top/fatih/color v1.17.0git.luolix.top/felixge/httpsnoop v1.0.4git.luolix.top/fsnotify/fsnotify v1.7.0git.luolix.top/getsentry/sentry-go v0.27.0git.luolix.top/go-kit/kit v0.13.0git.luolix.top/go-kit/log v0.2.1git.luolix.top/go-logfmt/logfmt v0.6.0git.luolix.top/godbus/dbus v0.0.0-20190726142602-4481cbc300e2git.luolix.top/gofrs/uuid v4.4.0+incompatiblegit.luolix.top/gogo/googleapis v1.4.1git.luolix.top/gogo/protobuf v1.3.2git.luolix.top/golang/glog v1.2.0git.luolix.top/golang/groupcache v0.0.0-20210331224755-41bb18bfe9dagit.luolix.top/golang/protobuf v1.5.4git.luolix.top/golang/snappy v0.0.4git.luolix.top/google/btree v1.1.2git.luolix.top/google/flatbuffers v2.0.8+incompatiblegit.luolix.top/google/go-cmp v0.6.0git.luolix.top/google/orderedcode v0.0.1git.luolix.top/gorilla/handlers v1.5.2git.luolix.top/gorilla/mux v1.8.1git.luolix.top/gorilla/websocket v1.5.3git.luolix.top/grpc-ecosystem/go-grpc-middleware v1.4.0git.luolix.top/grpc-ecosystem/grpc-gateway v1.16.0git.luolix.top/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910cgit.luolix.top/hashicorp/go-hclog v1.6.3git.luolix.top/hashicorp/go-immutable-radix v1.3.1git.luolix.top/hashicorp/go-metrics v0.5.3git.luolix.top/hashicorp/go-plugin v1.6.1git.luolix.top/hashicorp/golang-lru v1.0.2git.luolix.top/hashicorp/golang-lru/v2 v2.0.7git.luolix.top/hashicorp/hcl v1.0.0git.luolix.top/hashicorp/yamux v0.1.1git.luolix.top/hdevalence/ed25519consensus v0.2.0git.luolix.top/huandu/skiplist v1.2.0git.luolix.top/iancoleman/strcase v0.3.0git.luolix.top/inconshreveable/mousetrap v1.1.0git.luolix.top/jmhodges/levigo v1.0.0git.luolix.top/klauspost/compress v1.17.8git.luolix.top/kr/pretty v0.3.1git.luolix.top/kr/text v0.2.0git.luolix.top/lib/pq v1.10.9git.luolix.top/libp2p/go-buffer-pool v0.1.0git.luolix.top/linxGnu/grocksdb v1.8.14git.luolix.top/magiconair/properties v1.8.7git.luolix.top/mattn/go-colorable v0.1.13git.luolix.top/mattn/go-isatty v0.0.20git.luolix.top/minio/highwayhash v1.0.2git.luolix.top/mitchellh/go-testing-interface v1.14.1git.luolix.top/mitchellh/mapstructure v1.5.0git.luolix.top/mtibben/percent v0.2.1git.luolix.top/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822git.luolix.top/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09agit.luolix.top/oklog/run v1.1.0git.luolix.top/pelletier/go-toml/v2 v2.2.2git.luolix.top/petermattis/goid v0.0.0-20240327183114-c42a807a84bagit.luolix.top/pkg/errors v0.9.1git.luolix.top/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2git.luolix.top/prometheus/client_golang v1.19.1git.luolix.top/prometheus/client_model v0.6.1git.luolix.top/prometheus/common v0.55.0git.luolix.top/prometheus/procfs v0.15.1git.luolix.top/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475git.luolix.top/rogpeppe/go-internal v1.12.0git.luolix.top/rs/cors v1.11.0git.luolix.top/rs/zerolog v1.33.0git.luolix.top/sagikazarmark/locafero v0.4.0git.luolix.top/sagikazarmark/slog-shim v0.1.0git.luolix.top/sasha-s/go-deadlock v0.3.1git.luolix.top/sourcegraph/conc v0.3.0git.luolix.top/spf13/afero v1.11.0git.luolix.top/spf13/cast v1.6.0git.luolix.top/spf13/cobra v1.8.1git.luolix.top/spf13/pflag v1.0.5git.luolix.top/spf13/viper v1.19.0git.luolix.top/subosito/gotenv v1.6.0git.luolix.top/supranational/blst v0.3.12git.luolix.top/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6dgit.luolix.top/tendermint/go-amino v0.16.0git.luolix.top/tidwall/btree v1.7.0git.luolix.top/zondax/hid v0.9.2git.luolix.top/zondax/ledger-go v0.14.3gitlab.com/yawning/secp256k1-voi v0.0.0-20230925100816-f2616030848bgitlab.com/yawning/tuplehash v0.0.0-20230713102510-df83abbf9a02go.etcd.io/bbolt v1.4.0-alpha.0.0.20240404170359-43604f3112c5go.opencensus.io v0.24.0go.uber.org/multierr v1.11.0golang.org/x/crypto v0.25.0golang.org/x/exp v0.0.0-20240531132922-fd00a4e0eefcgolang.org/x/mod v0.17.0golang.org/x/net v0.27.0golang.org/x/sync v0.7.0golang.org/x/sys v0.22.0golang.org/x/term v0.22.0golang.org/x/text v0.16.0golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2dgoogle.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114degoogle.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237google.golang.org/genproto/googleapis/rpc v0.0.0-20240709173604-40e1e62336c5google.golang.org/grpc v1.64.1gopkg.in/ini.v1 v1.67.0gopkg.in/yaml.v3 v3.0.1gotest.tools/v3 v3.5.1pgregory.net/rapid v1.1.0sigs.k8s.io/yaml v1.4.0Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of listed indirect dependencies across the codebase. # Test: Search for indirect dependency versions in go.mod files. Expect: Consistent versions. rg --type go.mod -A 5 $'require ('Length of output: 104
Script:
#!/bin/bash # Description: Verify the consistency of listed indirect dependencies across the codebase. # Test: Search for indirect dependency versions in go.mod files. Expect: Consistent versions. rg --type go.mod -A 5 'require \('Length of output: 67
Script:
#!/bin/bash # Description: Verify the consistency of listed indirect dependencies across the codebase. # Locate all go.mod files and search for the 'require (' pattern within them. fd --type f --name go.mod --exec rg 'require \(' {}Length of output: 306
Script:
#!/bin/bash # Description: Verify the consistency of listed indirect dependencies across the codebase. # Locate all go.mod files and search for the 'require (' pattern within them. fd --type f --extension mod --exec rg 'require \(' {}Length of output: 1117
Script:
#!/bin/bash # Description: Verify the consistency of listed indirect dependencies across the codebase. # Locate all go.mod files and search for the 'require (' pattern within them, including filenames and context lines. fd --type f --extension mod --exec rg -H -A 10 'require \(' {}Length of output: 70135
|
You need to follow this as well https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#gomod |
Description
Closes: #20899
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
cosmossdk.io/x/accounts/defaults/multisig.