Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/prometheus/client_golang from 1.19.1 to 1.20.0 #21307

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 15, 2024

Bumps github.com/prometheus/client_golang from 1.19.1 to 1.20.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.20.0

Thanks everyone for contributions!

⚠️ In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

... (truncated)

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.20.0 / 2024-08-14

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

1.19.0 / 2024-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427

1.18.0 / 2023-12-22

  • [FEATURE] promlint: Allow creation of custom metric validations. #1311
  • [FEATURE] Go programs using client_golang can be built in wasip1 OS. #1350
  • [BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. #1367
  • [BUGFIX] testutil: Fix comparison of metrics with empty Help strings. #1378
  • [ENHANCEMENT] Improved performance of MetricVec.WithLabelValues(...). #1360

1.17.0 / 2023-09-27

  • [CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). #1325
  • [FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. #1313
  • [ENHANCEMENT] Enable detection of a native histogram without observations. #1314

1.16.0 / 2023-06-15

  • [BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. #1252
  • [BUGFIX] api: Fix undefined execution order in return statements. #1260
  • [BUGFIX] native histograms: Fix bug in bucket key calculation. #1279
  • [ENHANCEMENT] Reduce constrainLabels allocations for all metrics. #1272
  • [ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. #1278
  • [ENHANCEMENT] promlint: Improve metricUnits runtime. #1286

1.15.1 / 2023-05-3

  • [BUGFIX] Fixed promhttp.Instrument* handlers wrongly trying to attach exemplar to unsupported metrics (e.g. summary),
    causing panics. #1253

... (truncated)

Commits
  • 73b811c Cut 1.20.0 release. (#1580)
  • 7ce5089 gocollector: Attach original runtime/metrics metric name to help. (#1578)
  • 062300e Remove go_memstat_lookups_total; added runtime/metrics calculation to memstat...
  • aa3c00d Update common Prometheus files (#1576)
  • 3ad2722 Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /s...
  • 0715727 Update common Prometheus files (#1573)
  • 3634bd9 ci: daggerize test and lint pipelines (#1534)
  • 28b5e6e Merge pull request #1572 from prometheus/repo_sync
  • 8e18075 Update common Prometheus files
  • 46f77a9 Merge pull request #1571 from prometheus/dependabot/github_actions/github-act...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Chores
    • Updated various indirect dependencies to their latest versions for improved performance and security, including github.com/klauspost/compress and github.com/prometheus/client_golang.

These updates help maintain the overall stability and security of the application without introducing any changes to existing functionalities.

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner August 15, 2024 01:42
@dependabot dependabot bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file labels Aug 15, 2024
Copy link
Contributor

coderabbitai bot commented Aug 15, 2024

Walkthrough

Walkthrough

The changes across multiple Go module files involve the update of two indirect dependencies: github.com/klauspost/compress has been upgraded from version v1.17.8 to v1.17.9, and github.com/prometheus/client_golang has been updated from v1.19.1 to v1.20.0. These updates ensure that the libraries are current, likely addressing bugs and incorporating improvements without altering the core functionality of the applications.

Changes

Files Change Summary
client/v2/go.mod, go.mod, orm/go.mod, runtime/v2/go.mod, server/v2/cometbft/go.mod, server/v2/go.mod, simapp/go.mod, simapp/v2/go.mod, store/go.mod, store/v2/go.mod, tests/go.mod, tests/systemtests/go.mod, tools/confix/go.mod, tools/cosmovisor/go.mod, tools/hubl/go.mod, x/accounts/defaults/lockup/go.mod, x/accounts/defaults/multisig/go.mod, x/accounts/go.mod, x/auth/go.mod, x/authz/go.mod, x/bank/go.mod, x/circuit/go.mod, x/consensus/go.mod, x/distribution/go.mod, x/epochs/go.mod, x/evidence/go.mod, x/feegrant/go.mod, x/gov/go.mod, x/group/go.mod, x/mint/go.mod, x/nft/go.mod, x/params/go.mod, x/protocolpool/go.mod, x/slashing/go.mod, x/staking/go.mod, x/upgrade/go.mod Updates github.com/klauspost/compress from v1.17.8 to v1.17.9 and github.com/prometheus/client_golang from v1.19.1 to v1.20.0.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Go Module
    participant Dependency Manager

    Developer->>Go Module: Update dependencies
    Go Module->>Dependency Manager: Request dependency update
    Dependency Manager-->>Go Module: Fetch updated versions
    Go Module-->>Developer: Notify about updated dependencies
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0fe3115 and afc42a0.

Files ignored due to path filters (36)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • orm/go.sum is excluded by !**/*.sum
  • runtime/v2/go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • server/v2/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • store/go.sum is excluded by !**/*.sum
  • store/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • tests/systemtests/go.sum is excluded by !**/*.sum
  • tools/confix/go.sum is excluded by !**/*.sum
  • tools/cosmovisor/go.sum is excluded by !**/*.sum
  • tools/hubl/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (36)
  • client/v2/go.mod (2 hunks)
  • go.mod (2 hunks)
  • orm/go.mod (1 hunks)
  • runtime/v2/go.mod (2 hunks)
  • server/v2/cometbft/go.mod (2 hunks)
  • server/v2/go.mod (2 hunks)
  • simapp/go.mod (1 hunks)
  • simapp/v2/go.mod (1 hunks)
  • store/go.mod (2 hunks)
  • store/v2/go.mod (2 hunks)
  • tests/go.mod (1 hunks)
  • tests/systemtests/go.mod (2 hunks)
  • tools/confix/go.mod (2 hunks)
  • tools/cosmovisor/go.mod (1 hunks)
  • tools/hubl/go.mod (2 hunks)
  • x/accounts/defaults/lockup/go.mod (2 hunks)
  • x/accounts/defaults/multisig/go.mod (2 hunks)
  • x/accounts/go.mod (2 hunks)
  • x/auth/go.mod (2 hunks)
  • x/authz/go.mod (2 hunks)
  • x/bank/go.mod (2 hunks)
  • x/circuit/go.mod (2 hunks)
  • x/consensus/go.mod (2 hunks)
  • x/distribution/go.mod (2 hunks)
  • x/epochs/go.mod (2 hunks)
  • x/evidence/go.mod (2 hunks)
  • x/feegrant/go.mod (2 hunks)
  • x/gov/go.mod (2 hunks)
  • x/group/go.mod (2 hunks)
  • x/mint/go.mod (2 hunks)
  • x/nft/go.mod (2 hunks)
  • x/params/go.mod (2 hunks)
  • x/protocolpool/go.mod (2 hunks)
  • x/slashing/go.mod (2 hunks)
  • x/staking/go.mod (2 hunks)
  • x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (31)
  • client/v2/go.mod
  • go.mod
  • orm/go.mod
  • runtime/v2/go.mod
  • server/v2/cometbft/go.mod
  • server/v2/go.mod
  • store/go.mod
  • store/v2/go.mod
  • tests/systemtests/go.mod
  • tools/confix/go.mod
  • tools/hubl/go.mod
  • x/accounts/defaults/lockup/go.mod
  • x/accounts/defaults/multisig/go.mod
  • x/accounts/go.mod
  • x/auth/go.mod
  • x/authz/go.mod
  • x/bank/go.mod
  • x/circuit/go.mod
  • x/consensus/go.mod
  • x/distribution/go.mod
  • x/epochs/go.mod
  • x/evidence/go.mod
  • x/feegrant/go.mod
  • x/gov/go.mod
  • x/group/go.mod
  • x/mint/go.mod
  • x/nft/go.mod
  • x/params/go.mod
  • x/protocolpool/go.mod
  • x/slashing/go.mod
  • x/staking/go.mod
Additional context used
Path-based instructions (1)
tests/go.mod (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (5)
tools/cosmovisor/go.mod (1)

135-135: Upgrade dependency: Verify compatibility with client_golang v1.20.0.

The update to github.com/prometheus/client_golang v1.20.0 looks good. Ensure that the new version's changes, such as the removal of go_memstat_lookups_total and the introduction of new metrics, do not affect your application's functionality.

Verification successful

No compatibility issues found with client_golang v1.20.0

The updated version of github.com/prometheus/client_golang does not appear to impact your codebase based on the absence of the removed go_memstat_lookups_total metric and no usage of newly introduced metrics. Ensure to review other changes in the library for any additional impacts.

  • Files checked: telemetry/metrics.go, server/v2/api/telemetry/metrics.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for usage of removed or changed metrics in the codebase.

# Test: Search for the removed `go_memstat_lookups_total` metric. Expect: No occurrences.
rg --type go 'go_memstat_lookups_total'

# Test: Search for usage of new metrics. Expect: Occurrences if they are used.
rg --type go 'go_gc_gogc_percent|go_gc_gomemlimit_bytes|go_sched_gomaxprocs_threads'

Length of output: 126


Script:

#!/bin/bash
# Description: Check for any usage of the `prometheus/client_golang` package in the codebase.

# Search for any import statements or usage of the package to verify compatibility.
rg --type go 'prometheus/client_golang'

Length of output: 195


Script:

#!/bin/bash
# Description: Check for usage of specific metrics in files that import `prometheus/client_golang`.

# Check for usage of removed `go_memstat_lookups_total` metric.
rg 'go_memstat_lookups_total' telemetry/metrics.go server/v2/api/telemetry/metrics.go

# Check for usage of new metrics introduced in v1.20.0.
rg 'go_gc_gogc_percent|go_gc_gomemlimit_bytes|go_sched_gomaxprocs_threads' telemetry/metrics.go server/v2/api/telemetry/metrics.go

Length of output: 218

x/upgrade/go.mod (1)

153-153: Upgrade dependency: Verify compatibility with client_golang v1.20.0.

The update to github.com/prometheus/client_golang v1.20.0 is approved. Ensure that any changes in the new version, such as metric modifications, are compatible with your application's needs.

Verification successful

Compatibility Verified: client_golang v1.20.0 Upgrade

The upgrade to github.com/prometheus/client_golang v1.20.0 is compatible with the current usage in your codebase. The DefaultGatherer.Gather() method is used, and no deprecated or changed metrics were found that affect your implementation.

  • Files using Prometheus:
    • telemetry/metrics.go
    • server/v2/api/telemetry/metrics.go

No further action is required for compatibility.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for usage of removed or changed metrics in the codebase.

# Test: Search for the removed `go_memstat_lookups_total` metric. Expect: No occurrences.
rg --type go 'go_memstat_lookups_total'

# Test: Search for usage of new metrics. Expect: Occurrences if they are used.
rg --type go 'go_gc_gogc_percent|go_gc_gomemlimit_bytes|go_sched_gomaxprocs_threads'

Length of output: 126


Script:

#!/bin/bash
# Description: Find all usage of the `prometheus/client_golang` library to ensure compatibility.

# Search for any import statements related to `prometheus/client_golang`.
rg --type go 'import.*prometheus/client_golang' -A 5

# Search for any usage of the `prometheus` package in the codebase.
rg --type go 'prometheus\.' -A 3

Length of output: 650

tests/go.mod (1)

178-178: Upgrade dependency: Ensure test coverage for client_golang v1.20.0.

The update to github.com/prometheus/client_golang v1.20.0 is approved. Verify that your tests cover any new features or changes introduced in this version, such as the new metrics and any removed metrics.

simapp/go.mod (1)

180-180: Verify the impact of the dependency update.

The update to github.com/prometheus/client_golang v1.20.0 introduces new metrics and removes go_memstat_lookups_total. Ensure that the application correctly handles these changes, especially if it relies on the removed metric.

Verification successful

No Impact from Dependency Update

The update to github.com/prometheus/client_golang v1.20.0 does not affect the current codebase. The removed metric go_memstat_lookups_total and the new metrics introduced in this version are not used in the codebase. Therefore, no changes are required.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of removed and new metrics in the codebase.

# Test: Search for the removed `go_memstat_lookups_total` metric. Expect: No dependencies on this metric.
rg --type go 'go_memstat_lookups_total'

# Test: Search for the new metrics introduced in v1.20.0. Expect: Proper handling or usage.
rg --type go 'go_gc_gogc_percent|go_gc_gomemlimit_bytes|go_sched_gomaxprocs_threads'

Length of output: 126


Script:

#!/bin/bash
# Re-run the search for the removed `go_memstat_lookups_total` metric to verify no dependencies exist.
rg --type go 'go_memstat_lookups_total' --context 5

# Re-run the search for the new metrics introduced in v1.20.0 to verify proper handling or usage.
rg --type go 'go_gc_gogc_percent|go_gc_gomemlimit_bytes|go_sched_gomaxprocs_threads' --context 5

Length of output: 150

simapp/v2/go.mod (1)

186-186: Verify the impact of the dependency update.

The update to github.com/prometheus/client_golang v1.20.0 introduces new metrics and removes go_memstat_lookups_total. Ensure that the application correctly handles these changes, especially if it relies on the removed metric.

Verification successful

No Immediate Impact from Dependency Update

The update to github.com/prometheus/client_golang v1.20.0 does not currently impact the codebase, as the removed metric go_memstat_lookups_total is not used, and the new metrics are not yet integrated. Ensure future development considers integrating the new metrics if they are relevant to your application.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of removed and new metrics in the codebase.

# Test: Search for the removed `go_memstat_lookups_total` metric. Expect: No dependencies on this metric.
rg --type go 'go_memstat_lookups_total'

# Test: Search for the new metrics introduced in v1.20.0. Expect: Proper handling or usage.
rg --type go 'go_gc_gogc_percent|go_gc_gomemlimit_bytes|go_sched_gomaxprocs_threads'

Length of output: 126


Script:

#!/bin/bash
# Verify the introduction of new metrics in version 1.20.0 of `github.com/prometheus/client_golang`
# and check for any indirect usage patterns or different naming conventions.

# Fetch the changelog or release notes for version 1.20.0 to confirm new metrics.
gh release view v1.20.0 --repo prometheus/client_golang --json body --jq '.body'

# Search for any indirect usage patterns or different naming conventions related to new metrics.
rg --type go 'gogc|gomemlimit|gomaxprocs'

Length of output: 14654

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0fe3115 and afc42a0.

Files ignored due to path filters (36)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • orm/go.sum is excluded by !**/*.sum
  • runtime/v2/go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • server/v2/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • store/go.sum is excluded by !**/*.sum
  • store/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • tests/systemtests/go.sum is excluded by !**/*.sum
  • tools/confix/go.sum is excluded by !**/*.sum
  • tools/cosmovisor/go.sum is excluded by !**/*.sum
  • tools/hubl/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (36)
  • client/v2/go.mod (2 hunks)
  • go.mod (2 hunks)
  • orm/go.mod (1 hunks)
  • runtime/v2/go.mod (2 hunks)
  • server/v2/cometbft/go.mod (2 hunks)
  • server/v2/go.mod (2 hunks)
  • simapp/go.mod (1 hunks)
  • simapp/v2/go.mod (1 hunks)
  • store/go.mod (2 hunks)
  • store/v2/go.mod (2 hunks)
  • tests/go.mod (1 hunks)
  • tests/systemtests/go.mod (2 hunks)
  • tools/confix/go.mod (2 hunks)
  • tools/cosmovisor/go.mod (1 hunks)
  • tools/hubl/go.mod (2 hunks)
  • x/accounts/defaults/lockup/go.mod (2 hunks)
  • x/accounts/defaults/multisig/go.mod (2 hunks)
  • x/accounts/go.mod (2 hunks)
  • x/auth/go.mod (2 hunks)
  • x/authz/go.mod (2 hunks)
  • x/bank/go.mod (2 hunks)
  • x/circuit/go.mod (2 hunks)
  • x/consensus/go.mod (2 hunks)
  • x/distribution/go.mod (2 hunks)
  • x/epochs/go.mod (2 hunks)
  • x/evidence/go.mod (2 hunks)
  • x/feegrant/go.mod (2 hunks)
  • x/gov/go.mod (2 hunks)
  • x/group/go.mod (2 hunks)
  • x/mint/go.mod (2 hunks)
  • x/nft/go.mod (2 hunks)
  • x/params/go.mod (2 hunks)
  • x/protocolpool/go.mod (2 hunks)
  • x/slashing/go.mod (2 hunks)
  • x/staking/go.mod (2 hunks)
  • x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (32)
  • client/v2/go.mod
  • go.mod
  • orm/go.mod
  • runtime/v2/go.mod
  • server/v2/cometbft/go.mod
  • server/v2/go.mod
  • simapp/v2/go.mod
  • store/go.mod
  • store/v2/go.mod
  • tests/systemtests/go.mod
  • tools/confix/go.mod
  • tools/hubl/go.mod
  • x/accounts/defaults/lockup/go.mod
  • x/accounts/defaults/multisig/go.mod
  • x/accounts/go.mod
  • x/auth/go.mod
  • x/authz/go.mod
  • x/bank/go.mod
  • x/circuit/go.mod
  • x/consensus/go.mod
  • x/distribution/go.mod
  • x/epochs/go.mod
  • x/evidence/go.mod
  • x/feegrant/go.mod
  • x/gov/go.mod
  • x/group/go.mod
  • x/mint/go.mod
  • x/nft/go.mod
  • x/params/go.mod
  • x/protocolpool/go.mod
  • x/slashing/go.mod
  • x/staking/go.mod
Additional context used
Path-based instructions (1)
tests/go.mod (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (4)
tools/cosmovisor/go.mod (1)

135-135: Dependency Update: Prometheus Client Go

The github.com/prometheus/client_golang dependency has been updated to version 1.20.0. Ensure that any new features or changes introduced in this version are compatible with your application.

x/upgrade/go.mod (1)

153-153: Dependency Update: Prometheus Client Go

The github.com/prometheus/client_golang dependency has been updated to version 1.20.0. Verify that your application is compatible with any changes introduced in this version.

tests/go.mod (1)

178-178: Dependency Update: Prometheus Client Go

The github.com/prometheus/client_golang dependency has been updated to version 1.20.0. Ensure that your integration and end-to-end tests cover any new features or changes introduced in this version.

simapp/go.mod (1)

180-180: Verify the impact of updating github.com/prometheus/client_golang to v1.20.0.

Ensure that the removal of the go_memstat_lookups_total metric and the addition of new metrics (go_gc_gogc_percent, go_gc_gomemlimit_bytes, go_sched_gomaxprocs_threads) do not affect the application's functionality. Check for any deprecated or removed metrics and update the code accordingly.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0fe3115 and afc42a0.

Files ignored due to path filters (36)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • orm/go.sum is excluded by !**/*.sum
  • runtime/v2/go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • server/v2/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • store/go.sum is excluded by !**/*.sum
  • store/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • tests/systemtests/go.sum is excluded by !**/*.sum
  • tools/confix/go.sum is excluded by !**/*.sum
  • tools/cosmovisor/go.sum is excluded by !**/*.sum
  • tools/hubl/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (36)
  • client/v2/go.mod (2 hunks)
  • go.mod (2 hunks)
  • orm/go.mod (1 hunks)
  • runtime/v2/go.mod (2 hunks)
  • server/v2/cometbft/go.mod (2 hunks)
  • server/v2/go.mod (2 hunks)
  • simapp/go.mod (1 hunks)
  • simapp/v2/go.mod (1 hunks)
  • store/go.mod (2 hunks)
  • store/v2/go.mod (2 hunks)
  • tests/go.mod (1 hunks)
  • tests/systemtests/go.mod (2 hunks)
  • tools/confix/go.mod (2 hunks)
  • tools/cosmovisor/go.mod (1 hunks)
  • tools/hubl/go.mod (2 hunks)
  • x/accounts/defaults/lockup/go.mod (2 hunks)
  • x/accounts/defaults/multisig/go.mod (2 hunks)
  • x/accounts/go.mod (2 hunks)
  • x/auth/go.mod (2 hunks)
  • x/authz/go.mod (2 hunks)
  • x/bank/go.mod (2 hunks)
  • x/circuit/go.mod (2 hunks)
  • x/consensus/go.mod (2 hunks)
  • x/distribution/go.mod (2 hunks)
  • x/epochs/go.mod (2 hunks)
  • x/evidence/go.mod (2 hunks)
  • x/feegrant/go.mod (2 hunks)
  • x/gov/go.mod (2 hunks)
  • x/group/go.mod (2 hunks)
  • x/mint/go.mod (2 hunks)
  • x/nft/go.mod (2 hunks)
  • x/params/go.mod (2 hunks)
  • x/protocolpool/go.mod (2 hunks)
  • x/slashing/go.mod (2 hunks)
  • x/staking/go.mod (2 hunks)
  • x/upgrade/go.mod (1 hunks)
Files skipped from review due to trivial changes (32)
  • client/v2/go.mod
  • go.mod
  • orm/go.mod
  • runtime/v2/go.mod
  • server/v2/cometbft/go.mod
  • server/v2/go.mod
  • simapp/v2/go.mod
  • store/go.mod
  • store/v2/go.mod
  • tests/systemtests/go.mod
  • tools/confix/go.mod
  • tools/hubl/go.mod
  • x/accounts/defaults/lockup/go.mod
  • x/accounts/defaults/multisig/go.mod
  • x/accounts/go.mod
  • x/auth/go.mod
  • x/authz/go.mod
  • x/bank/go.mod
  • x/circuit/go.mod
  • x/consensus/go.mod
  • x/distribution/go.mod
  • x/epochs/go.mod
  • x/evidence/go.mod
  • x/feegrant/go.mod
  • x/gov/go.mod
  • x/group/go.mod
  • x/mint/go.mod
  • x/nft/go.mod
  • x/params/go.mod
  • x/protocolpool/go.mod
  • x/slashing/go.mod
  • x/staking/go.mod
Additional context used
Path-based instructions (1)
tests/go.mod (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (4)
tools/cosmovisor/go.mod (1)

135-135: Dependency update approved.

The update of github.com/prometheus/client_golang from v1.19.1 to v1.20.0 is consistent with the PR objectives and release notes. No issues found.

x/upgrade/go.mod (1)

153-153: Dependency update approved.

The update of github.com/prometheus/client_golang from v1.19.1 to v1.20.0 is consistent with the PR objectives and release notes. No issues found.

tests/go.mod (1)

178-178: Dependency update approved.

The update of github.com/prometheus/client_golang from v1.19.1 to v1.20.0 is consistent with the PR objectives and release notes. No issues found.

Additionally, ensure that the integration and end-to-end tests cover the changes associated with this dependency update.

simapp/go.mod (1)

180-180: Verify compatibility with github.com/prometheus/client_golang v1.20.0.

Ensure that the application is compatible with the new version of the Prometheus client library, as there may be changes in metrics and API usage. Review the release notes for any breaking changes or new features that need to be integrated.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit 55a6085 Aug 15, 2024
94 of 103 checks passed
@julienrbrt julienrbrt deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.20.0 branch August 15, 2024 10:46
alpe added a commit that referenced this pull request Aug 19, 2024
* main: (76 commits)
  docs: more app v2 renaming (#21336)
  chore: update link in disclaimer (#21339)
  refactor(x/distribution): audit QA (#21316)
  docs: rename app v2 to app di when talking about runtime v0 (#21329)
  feat(schema): specify JSON mapping (#21243)
  fix(x/authz): bring back msg response in `DispatchActions` (#21044)
  chore: fix all lint issue since golangci-lint bump (#21326)
  refactor(x/mint): v0.52 audit x/mint (#21301)
  chore: fix spelling errors (#21327)
  feat: export genesis in simapp v2 (#21199)
  fix(baseapp)!: Halt at height now does not produce the halt height block (#21256)
  refactor(scripts): remove unused variable (#21320)
  chore(schema/testing): upgrade to go 1.23 iterators (#21282)
  chore: readmes + upgrading docs (#21271)
  feat(client): add auto cli for node service (#21074)
  ci: fix github workflow vulnerable to script injection (#21304)
  build(deps): Bump github.com/prometheus/client_golang from 1.19.1 to 1.20.0 (#21307)
  build(deps): use Go 1.23 instead of Go 1.22 (#21280)
  refactor(x/auth): audit x/auth changes (#21146)
  chore: remove todo: "abstract out staking message back to staking" (#21266)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants