-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/bank): Better handling of negative spendable balances #21407
Commits on Aug 23, 2024
-
Update the SpendableBalances query endpoint function. Now, it'll bene…
…fit from the pagination by subtracting locked coins instead of selecting the desired entries out of the k.SpendableCoins results. That k.SpendableCoins method first gets all balances, then subtracts the locked coins. So this query was effectively getting all balances every time instead of only info on the current page's entries.
Configuration menu - View commit details
-
Copy full SHA for 6b00b93 - Browse repository at this point
Copy the full SHA 6b00b93View commit details -
Update the SpendableCoins view keeper method to better handle when on…
…e denom is negative; now it'll treat just that one as zero instead of the entire spendable balance. Also update SpendableCoin to not panic when there's more locked than available; just return a zero coin in that case.
Configuration menu - View commit details
-
Copy full SHA for 49a7712 - Browse repository at this point
Copy the full SHA 49a7712View commit details
Commits on Aug 24, 2024
-
Add some unit tests that hit the spendable balance edge cases (and wo…
…uld fail without this change).
Configuration menu - View commit details
-
Copy full SHA for ff781b5 - Browse repository at this point
Copy the full SHA ff781b5View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f5043dd - Browse repository at this point
Copy the full SHA f5043ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04fd051 - Browse repository at this point
Copy the full SHA 04fd051View commit details -
Fix a variable name in the keeper test that I accidentally added a ch…
…ar to when not looking.
Configuration menu - View commit details
-
Copy full SHA for e2b125c - Browse repository at this point
Copy the full SHA e2b125cView commit details -
Fix the integration test on SpendableBalances that broke because the …
…gas cost went down with this change.
Configuration menu - View commit details
-
Copy full SHA for 350c21b - Browse repository at this point
Copy the full SHA 350c21bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0afa21 - Browse repository at this point
Copy the full SHA d0afa21View commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b99cf6f - Browse repository at this point
Copy the full SHA b99cf6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b474a6 - Browse repository at this point
Copy the full SHA 5b474a6View commit details