feat(x/bank): add origin address in event multisend #21460
Conversation
julienrbrt
added
backport/v0.50.x
WalkthroughWalkthroughThe changes enhance the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/bank/keeper/send.go (1 hunks)
Additional context used
Path-based instructions (1)
x/bank/keeper/send.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (1)
x/bank/keeper/send.go (1)
175-177: LGTM!The addition of the sender attribute to the event emission process enhances the traceability of transactions by including the sender's address in the emitted event.
|
@julienrbrt your pull request is missing a changelog! |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/bank/keeper/keeper_test.go (1 hunks)
Additional context used
Path-based instructions (1)
x/bank/keeper/keeper_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (2)
x/bank/keeper/keeper_test.go (2)
1471-1472: Include the sender attribute in the event.The sender attribute is correctly added to the event attributes.
The code changes are approved.
1482-1483: Include the sender attribute in the event.The sender attribute is correctly added to the event attributes.
The code changes are approved.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/bank/keeper/keeper_test.go (1 hunks)
Additional context used
Path-based instructions (1)
x/bank/keeper/keeper_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (2)
x/bank/keeper/keeper_test.go (2)
1471-1472: LGTM!The sender attribute is correctly added to the event attributes.
1482-1482: LGTM!The sender attribute is correctly added to the event attributes.
(cherry picked from commit 33c463e)
(cherry picked from commit 33c463e) # Conflicts: # x/bank/keeper/keeper_test.go # x/bank/keeper/send.go
Description
Closes: #21414
I'll add a changelog in v0.50 only.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit