Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PENDING.md #2160

Closed
wants to merge 1 commit into from
Closed

Update PENDING.md #2160

wants to merge 1 commit into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 27, 2018

Closes: #1712

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #2160 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2160   +/-   ##
========================================
  Coverage    63.91%   63.91%           
========================================
  Files          134      134           
  Lines         8194     8194           
========================================
  Hits          5237     5237           
  Misses        2604     2604           
  Partials       353      353

@cwgoes
Copy link
Contributor

cwgoes commented Aug 27, 2018

How does this PR fix the problem? Don't we need to update the Tendermint dependency?

@ValarDragon
Copy link
Contributor

We shouldn't do this until we update to the correct tm version imo. I'm not opposed to linking SDK develop to a specific revision of tendermint though. (Will make the later upgrade easier)

@alessio
Copy link
Contributor Author

alessio commented Aug 27, 2018

Yes, I think we need to upgrade the dep.

@rigelrozanski
Copy link
Contributor

changed to WIP as there is only a pending update, not code yet

@alessio
Copy link
Contributor Author

alessio commented Aug 27, 2018

@rigelrozanski othen than a refresh in Gopkg.toml, there will hardly be code coming out of this. The bug should have been filed against tendermint in the first place

@ValarDragon
Copy link
Contributor

Can we close this in favor of #2219 then?

@cwgoes
Copy link
Contributor

cwgoes commented Sep 4, 2018

Closing in favor of #2219 - @alessio if you want to push to the latter PR, feel free.

@cwgoes cwgoes closed this Sep 4, 2018
@cwgoes cwgoes deleted the alessio/1712-config-db_path branch September 4, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants