Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(baseapp): populate header info in NewUncachedContext #22557

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix(baseapp): populate header info in NewUncachedContext #22557

merged 2 commits into from
Nov 20, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 19, 2024 •
edited by coderabbitai bot
Loading

Description

Closes: #22507

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Enhanced context management by integrating additional header information in the context creation process.
  • Bug Fixes
    • Simplified context creation by removing unnecessary header information in certain scenarios.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2024 •
edited
Loading

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request enhance the context creation methods in the baseapp/test_helpers.go file by integrating additional header information through the NewUncachedContext method. A new import for coreheader is added, and the method now utilizes WithHeaderInfo to include block height and time. The NewContextLegacy method has been modified for improved readability, while the NewContext method remains unchanged. In contrast, the NextBlock function in testutil/sims/app_helpers.go has been simplified by removing the WithHeaderInfo call, resulting in context creation without additional header information.

Changes

File Path Change Summary
baseapp/test_helpers.go - Enhanced NewUncachedContext to include WithHeaderInfo(coreheader.Info{...}).
- Updated NewContextLegacy for improved readability by separating method calls.
testutil/sims/app_helpers.go - Removed WithHeaderInfo call from NewUncachedContext, simplifying context creation.

Assessment against linked issues

Objective Addressed Explanation
Ensure headerInfo is set in baseapp.NewUncachedContext (22507) ✅

Possibly related PRs

Suggested labels

backport/v0.52.x

Suggested reviewers

  • aaronc
  • kocubinski
  • tac0turtle
  • facundomedica

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt julienrbrt requested a review from Copilot November 19, 2024 18:13
Copilot
Copilot AI reviewed Nov 19, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
@julienrbrt julienrbrt added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 3d618f5 Nov 20, 2024
71 of 72 checks passed
@julienrbrt julienrbrt deleted the julien/uncached-ctx branch November 20, 2024 07:08
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@julienrbrt @mergify
fix(baseapp): populate header info in NewUncachedContext (#22557)
3ed8a88 
(cherry picked from commit 3d618f5)
@mergify mergify bot mentioned this pull request Nov 20, 2024
Merged
12 tasks
julienrbrt pushed a commit that referenced this pull request Nov 20, 2024
@mergify
fix(baseapp): populate header info in NewUncachedContext (backport #…
7c1bb02 
…22557) (#22565)
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
Merged
12 tasks
alpe added a commit that referenced this pull request Nov 21, 2024
@alpe
Merge branch 'main' into alex/sam/dec-type
0130357 
* main:
  build(deps): Bump cosmossdk.io/math from 1.3.0 to 1.4.0 (#22580)
  fix(server/v2/api/telemetry): enable global metrics  (#22571)
  refactor(server/v2/cometbft): add `codec.Codec` and clean-up APIs (#22566)
  feat(core/coretesting): make memDB satisfy db.Db interface (#22570)
  Merge commit from fork
  fix(server(/v2)): fix fallback genesis path (#22564)
  fix: only overwrite context chainID when necessary (#22568)
  docs(client): Update setFeeGranter and setFeePayer comments (#22526)
  fix(baseapp): populate header info in `NewUncachedContext` (#22557)
  build(deps): Bump buf.build/gen/go/cometbft/cometbft/protocolbuffers/go from 1.35.1-20240701160653-fedbb9acfd2f.1 to 1.35.2-20240701160653-fedbb9acfd2f.1 in /api (#22551)
  build(deps): Bump github.com/creachadair/atomicfile from 0.3.5 to 0.3.6 in /tools/confix (#22552)
  docs: Update reference of Approximation (#22550)
  fix(server/v2/comebft): wire missing services + fix simulation (#21964)
  ci: fix permissions for GITHUB_TOKEN on dependabot workflows (#22547)
  ci: fix permissions for GITHUB_TOKEN in spell check workflow (#22545)
  build(deps): Bump google.golang.org/protobuf from 1.35.1 to 1.35.2 (#22537)
  fix(cosmovisor): premature upgrade on restart (#22528)
  fix(store/v2/pebble): handle version 0 in keys (#22524)
  refactor(server/v2/telemetry): swap redirects (#22520)
  docs: Update content in  CODE_OF_CONDUCT.md (#22518)
@coderabbitai coderabbitai bot mentioned this pull request Nov 22, 2024
Merged
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 3, 2024
Merged
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 19, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@hieuvubk hieuvubk hieuvubk approved these changes

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees

@aaronc aaronc

@kocubinski kocubinski

@facundomedica facundomedica

@testinginprod testinginprod

Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: headerInfo not set in baseapp.NewUncachedContext
8 participants
@julienrbrt @tac0turtle @sontrinh16 @hieuvubk @aaronc @kocubinski @facundomedica @testinginprod