-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prep collections v1 and api v0.8.0 #23198
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ module github.com/cosmos/cosmos-sdk | |
require ( | ||
cosmossdk.io/api v0.8.0-rc.3 | ||
cosmossdk.io/collections v1.0.0-rc.1 | ||
cosmossdk.io/core v1.0.0-alpha.6 | ||
cosmossdk.io/core v1.0.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Version mismatch detected in server/v2/appmanager While most modules are correctly aligned with
🔗 Analysis chainVerify ecosystem impact of core v1.0.0. The update to Run this script to analyze the impact: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for potential incompatibilities across the ecosystem
# Find all go.mod files and verify core version consistency
fd -e mod --exec grep -l "cosmossdk.io/core"
# Check for any conditional imports or version-specific code
rg -t go "core\." --glob "!vendor/*" -A 3
Length of output: 2368 Script: #!/bin/bash
# Check specific core versions across all modules
fd -e mod --exec grep -A 1 "cosmossdk.io/core" {}
# Look for any version constraints
rg -g "go.mod" "require.*cosmossdk.io/core.*" -A 2
Length of output: 4755
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
cosmossdk.io/core/testing v0.0.1 | ||
cosmossdk.io/depinject v1.1.0 | ||
cosmossdk.io/errors v1.0.1 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ replace ( | |
require ( | ||
cosmossdk.io/api v0.8.0-rc.3 | ||
cosmossdk.io/collections v1.0.0-rc.1 | ||
cosmossdk.io/core v1.0.0-alpha.6 | ||
cosmossdk.io/core v1.0.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Version inconsistency detected: Multiple modules still use alpha versions Several modules still use
🔗 Analysis chainLGTM: Version update aligns with release preparation. The update of Run the following script to verify version consistency across the repository: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any remaining alpha versions of cosmossdk.io/core
# and verify consistency with other core dependencies
# Check for any remaining alpha versions
rg -g 'go.mod' 'cosmossdk.io/core v1.0.0-alpha'
# List all unique versions of core dependencies for verification
echo "Core dependency versions:"
rg -g 'go.mod' '^[[:space:]]*cosmossdk.io/(api|collections|core) v[0-9]' -A 1
Length of output: 9509 |
||
cosmossdk.io/errors v1.0.1 | ||
cosmossdk.io/errors/v2 v2.0.0 | ||
cosmossdk.io/log v1.5.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ go 1.23.2 | |
require ( | ||
cosmossdk.io/api v0.8.0-rc.3 | ||
cosmossdk.io/collections v1.0.0-rc.1 | ||
cosmossdk.io/core v1.0.0-alpha.6 | ||
cosmossdk.io/core v1.0.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Version inconsistency detected across modules The update to
🔗 Analysis chainVerify compatibility with dependent modules. The update from Run the following script to check for potential compatibility issues: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if any dependent modules are still using the alpha version of core.
# Search for any remaining alpha versions of core
rg -l "cosmossdk.io/core v1.0.0-alpha" --type go
Length of output: 50 Script: #!/bin/bash
# Find all go.mod files and check their core dependency versions
fd go.mod --type f --exec sh -c 'echo "=== {} ==="; grep "cosmossdk.io/core" {} || true'
Length of output: 4182 |
||
cosmossdk.io/core/testing v0.0.1 | ||
cosmossdk.io/depinject v1.1.0 | ||
cosmossdk.io/schema v1.0.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid Go version specified
The Go version
1.23.2
specified in thego.mod
file is invalid as it doesn't exist yet. The latest stable version of Go is 1.22.📝 Committable suggestion