Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove baseapp and sdk.Context fully from x/upgrade #23396

Merged
merged 82 commits into from
Feb 5, 2025

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Jan 15, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced an enhanced branch service mock to improve backend testing simulations.
  • Tests

    • Streamlined test setups with improved context handling and enhanced transaction encoding/decoding for more reliable integration.
  • Chores

    • Upgraded dependency versions and simplified configuration directives across multiple modules for improved stability and maintainability.

@julienrbrt julienrbrt enabled auto-merge February 5, 2025 12:22
@julienrbrt julienrbrt added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 9ea03a3 Feb 5, 2025
87 of 89 checks passed
@julienrbrt julienrbrt deleted the chore/remove-baseapp-upgrade branch February 5, 2025 12:36
mergify bot pushed a commit that referenced this pull request Feb 5, 2025
Co-authored-by: aljo242 <alex@skip.money>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 9ea03a3)

# Conflicts:
#	client/v2/go.mod
#	client/v2/go.sum
#	core/testing/environment.go
#	go.mod
#	simapp/go.mod
#	simapp/go.sum
#	tests/go.mod
#	tools/benchmark/go.mod
#	x/accounts/defaults/base/go.mod
#	x/accounts/defaults/lockup/go.mod
#	x/accounts/defaults/multisig/go.mod
#	x/accounts/go.mod
#	x/accounts/go.sum
#	x/authz/go.mod
#	x/authz/go.sum
#	x/bank/go.mod
#	x/bank/go.sum
#	x/circuit/go.mod
#	x/consensus/go.mod
#	x/distribution/go.mod
#	x/epochs/go.mod
#	x/evidence/go.mod
#	x/feegrant/go.mod
#	x/gov/go.mod
#	x/gov/go.sum
#	x/group/go.mod
#	x/group/go.sum
#	x/mint/go.mod
#	x/nft/go.mod
#	x/params/CHANGELOG.md
#	x/params/branch.go
#	x/params/go.mod
#	x/protocolpool/go.mod
#	x/slashing/go.mod
#	x/staking/go.mod
#	x/upgrade/go.mod
@julienrbrt julienrbrt removed the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants