-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix the outdated description of transaction.Msg
#23409
Conversation
📝 WalkthroughWalkthroughThe pull request updates the documentation for the Changes
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/build/building-modules/02-messages-and-queries.md (1)
41-41
: Consider adding more context about structural types.While the description is accurate, it would be helpful to add a brief explanation of what structural types are and why they're used for defining the message interface. This would provide better clarity for developers.
-`transaction.Msg` uses structural types to define the interface for a message. +`transaction.Msg` uses structural types to define the interface for a message. Structural types allow the interface to be implemented based on the structure and methods of a type, rather than explicit interface implementation.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/build/building-modules/02-messages-and-queries.md
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/build/building-modules/02-messages-and-queries.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: repo-analysis
- GitHub Check: build (arm64)
- GitHub Check: build (amd64)
- GitHub Check: markdown-link-check
- GitHub Check: dependency-review
- GitHub Check: Summary
🔇 Additional comments (1)
docs/build/building-modules/02-messages-and-queries.md (1)
44-44
: LGTM!The reference link is correctly updated to point to the current implementation of the
transaction.Msg
interface.
Co-authored-by: Alex | Interchain Labs <alex@skip.money> (cherry picked from commit adc1d31)
) (#23425) Co-authored-by: SuiYuan <suiyuan.wood@gmail.com>
Description
#21239 has made a change for
transaction.Msg
, now it's no longer an alias ofproto.Message
Summary by CodeRabbit
transaction.Msg
interface