Pause: Circuit Breaker 1

[mossid]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

Dependent on: #2491

Addresses: #3234

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (joon/paramstore-subkey@078aead). Click here to learn what that means.
The diff coverage is 43.56%.

@@                    Coverage Diff                    @@
##             joon/paramstore-subkey    #2497   +/-   ##
=========================================================
  Coverage                          ?   53.17%           
=========================================================
  Files                             ?      132           
  Lines                             ?     9690           
  Branches                          ?        0           
=========================================================
  Hits                              ?     5153           
  Misses                            ?     4224           
  Partials                          ?      313

[alexanderbez]

@mossid can we separate out the changes to the param store into a separate PR?

[sunnya97]

Why do we need a new module for this instead adding it to the current AnteHandler?

[cwgoes]

Should we write a spec for the circuit breaker (even this non-governance part)?

[mossid]

@sunnya97 auth module is mainly for account verification including nonce and signature verification, so I think it is better to separate out to another module since it is for verifying module's availability.

[alexanderbez]

@mossid is there a spec for this I can look at? It'll help me review the code better.

[ValarDragon]

Ideally we want composability of ante handlers, so this would make sense as a composition on top of our current ante handler. We probably don't have composability atm though.

[cwgoes]

@mossid Checking in on this PR - #2491 has since been merged - should we rebase this on develop? Can we write a spec or at least an issue describing what this PR intends to accomplish?

[alexanderbez]

It seems this branch is severely out of date :(

[cwgoes]

Needs to be rebased and retargeted against develop if we want to consider merging this.

[rigelrozanski]

Can we rename to Pause State or "Pausing" - wherever relevant? thoughts? (discussed here #2935)

[jackzampolin]

I think we need to circle up as team and decide what we want out of this feature and write some spec on it.