Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Rename AccountMapper to AccountKeeper #2545

Merged
merged 2 commits into from
Oct 21, 2018
Merged

R4R: Rename AccountMapper to AccountKeeper #2545

merged 2 commits into from
Oct 21, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Oct 21, 2018 •
edited
Loading

Closes: #2540

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio requested a review from zramsay as a code owner October 21, 2018 06:24
@codecov
Copy link

codecov bot commented Oct 21, 2018 •
edited
Loading

Codecov Report

Merging #2545 into develop will not change coverage.
The diff coverage is 84.61%.

@@           Coverage Diff            @@
##           develop    #2545   +/-   ##
========================================
  Coverage    60.28%   60.28%           
========================================
  Files          150      150           
  Lines         8589     8589           
========================================
  Hits          5178     5178           
  Misses        3067     3067           
  Partials       344      344

@alessio alessio requested a review from alexanderbez October 21, 2018 06:58
cwgoes
cwgoes approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @alessio

@cwgoes cwgoes merged commit 3e22a36 into develop Oct 21, 2018
@cwgoes cwgoes deleted the alessio/2540-rename-AccountMapper-to-AccountKeeper branch October 21, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@sunnya97 sunnya97 Awaiting requested review from sunnya97

@ebuchman ebuchman Awaiting requested review from ebuchman

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@zramsay zramsay Awaiting requested review from zramsay

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio @cwgoes