Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Various sign command improvements #2558

Merged
merged 19 commits into from
Oct 31, 2018
Merged

R4R: Various sign command improvements #2558

merged 19 commits into from
Oct 31, 2018

Commits on Oct 31, 2018

  1. Various sign command improvements 

    - Exit with error if the user is attempting to sign with a key
  whose address is not among those who are expected to sign
  the transaction.

- Add --print-signature-only to output only the generated
  signature.
    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    bc583ab View commit details
    Browse the repository at this point in the history

  2. Check sanity of signatures and report errors when run with --print-sigs

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    933592d View commit details
    Browse the repository at this point in the history

  3. Improve errors reporting

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    4bf17e8 View commit details
    Browse the repository at this point in the history

  4. Improve online docs

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    62974e6 View commit details
    Browse the repository at this point in the history

  5. Refresh PENDING.md

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    a4c4e28 View commit details
    Browse the repository at this point in the history

  6. Find better name for --print-signature-only

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    69a7c06 View commit details
    Browse the repository at this point in the history

  7. Fix integration tests

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    e65c02d View commit details
    Browse the repository at this point in the history

  8. Validate --name

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    31c0626 View commit details
    Browse the repository at this point in the history

  9. Fix integration tests

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    a514295 View commit details
    Browse the repository at this point in the history

  10. s/--print-sigs/--validate-signatures/

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    53f1233 View commit details
    Browse the repository at this point in the history

  11. s/--sig-only/--signature-only/

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    f752525 View commit details
    Browse the repository at this point in the history

  12. Docs updated

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    bb734c4 View commit details
    Browse the repository at this point in the history

  13. Update PENDING.md

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    17f799a View commit details
    Browse the repository at this point in the history

  14. Rename append, it's go builtin

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    9e39790 View commit details
    Browse the repository at this point in the history

  15. Set success = false when it fails

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    44d2347 View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from bez

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    84aef0d View commit details
    Browse the repository at this point in the history

  17. Nest switches

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    6c8791f View commit details
    Browse the repository at this point in the history

  18. Fix rebase

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    06989be View commit details
    Browse the repository at this point in the history

  19. Document what --validate-signatures does

    Alessio Treglia committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    dbbf064 View commit details
    Browse the repository at this point in the history