Bugfix: stable app hash #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
catShaark
referenced
this pull request
in notional-labs/cosmos-sdk
Jun 29, 2022
* Bring back the cliff vesting command osmosis-labs#111 * Wrap error
brendan-kelly
referenced
this pull request
in figment-networks/cosmos-sdk
Aug 3, 2022
) * feat!: bring back the cliff vesting command (#111) (#271) * Bring back the cliff vesting command osmosis-labs#111 * Wrap error (cherry picked from commit bf5b163) # Conflicts: # x/auth/vesting/client/cli/tx.go * fix conflict * Fix merge conflict Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Reecepbcups
pushed a commit
to Reecepbcups/cosmos-sdk
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caching was writing cached reads again, which apparently changed the app hash (as the height of the node changed, even if the data didn't). This means the AppHash changes even in blocks with no tx.
This was exposed by a combination of historical queries and the ticker in gaia. But was a hidden bug in cosmos-sdk since the Canada retreat....
If we can merge this, we can save gaia!