R4R: Remove AppInit #2801
Merged
R4R: Remove AppInit #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2801 +/- ##
========================================
Coverage 56.73% 56.73%
========================================
Files 131 131
Lines 8554 8554
========================================
Hits 4853 4853
Misses 3368 3368
Partials 333 333 |
| @@ -98,11 +98,6 @@ The `simplegovd` command will run the daemon server as a background process. Fir | |||
|
|
|||
| ```go | |||
| // cmd/simplegovd/main.go | |||
| // SimpleGovAppInit initial parameters | |||
There was a problem hiding this comment.
One small note here, I think this is getting moved in the docs update. I have a feeling that is going to merge first, so this will be a merge conflict.
|
Looks good and doesn't break anything when I run locally. Can you provide a bit more info on why this change was made and if there are any user facing side effects? |
27 tasks
|
@jackzampolin Code cleanup, AppInit is no longer required. Updated description. |
alexanderbez
suggested changes
Nov 15, 2018
alessio
force-pushed
the
alessio/app-init-cleanup
branch
from
ec8ef6c
to
005f1b8
Compare
alexanderbez
approved these changes
Nov 15, 2018
added 2 commits
November 15, 2018 16:38
alessio
force-pushed
the
alessio/app-init-cleanup
branch
from
005f1b8
to
8ba7689
Compare
This was referenced Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking #2675 up from where @jaekwon left it.
Code cleanup, AppInit is no longer required.
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: