-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R] Change gas & related fields to unsigned integer type #2839
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2839 +/- ##
===========================================
- Coverage 57% 56.83% -0.18%
===========================================
Files 131 131
Lines 8581 8575 -6
===========================================
- Hits 4892 4874 -18
- Misses 3359 3370 +11
- Partials 330 331 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consume gas should check for overflow
Yes @ValarDragon -- the PR is not complete yet. |
Failing due to a regression in #2781. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK
This has been addressed by subsequent commits.
* Updates for Gaia v14 (aka v14.1.0) * Some minor updates
Update gas consumption and fields to utilize
uint64
overint64
. I believe the corresponding changes should also be made in TM forabci.ResponseDeliverTx
,abci.ResponseCheckTx
, andBlockSize.MaxGas
so we don't have to cast.closes: #2815
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: