R4R: Add fees and memo to REST, updated CLI to receive coins as fees

PENDING.md

@@ -3,11 +3,13 @@
 BREAKING CHANGES
 
 * Gaia REST API (`gaiacli advanced rest-server`)
+  * [gaia-lite] [\#2182] Renamed and merged all redelegations endpoints into `/stake/redelegations`
 
 * Gaia CLI  (`gaiacli`)
   * [\#810](https://github.com/cosmos/cosmos-sdk/issues/810) Don't fallback to any default values for chain ID.
-    - Users need to supply chain ID either via config file or the `--chain-id` flag.
-    - Change `chain_id` and `trust_node` in `gaiacli` configuration to `chain-id` and `trust-node` respectively.
+    * Users need to supply chain ID either via config file or the `--chain-id` flag.
+    * Change `chain_id` and `trust_node` in `gaiacli` configuration to `chain-id` and `trust-node` respectively.
+  * [\#3069](https://github.com/cosmos/cosmos-sdk/pull/3069) `--fee` flag renamed to `--fees` to support multiple coins
   * [\#3156](https://github.com/cosmos/cosmos-sdk/pull/3156) Remove unimplemented `gaiacli init` command
 
 * Gaia
@@ -21,14 +23,13 @@ BREAKING CHANGES
 FEATURES
 
 * Gaia REST API (`gaiacli advanced rest-server`)
-    * [gaia-lite] [\#2182] Added LCD endpoint for querying redelegations
-    * [gov] [\#2479](https://github.com/cosmos/cosmos-sdk/issues/2479) Added governance parameter
-    query REST endpoints.
+  * [\#3067](https://github.com/cosmos/cosmos-sdk/issues/3067) Add support for fees on transactions
+  * [\#3069](https://github.com/cosmos/cosmos-sdk/pull/3069) Add a custom memo on transactions
 
 * Gaia CLI  (`gaiacli`)
+  * \#2399 Implement `params` command to query slashing parameters.
 
 * Gaia
-
     * [\#2182] [x/stake] Added querier for querying a single redelegation
 
 * SDK

client/flags.go

@@ -1,6 +1,7 @@
 package client
 
 import (
+	"errors"
 	"fmt"
 	"strconv"
 
@@ -29,7 +30,7 @@ const (
 	FlagAccountNumber      = "account-number"
 	FlagSequence           = "sequence"
 	FlagMemo               = "memo"
-	FlagFee                = "fee"
+	FlagFees               = "fees"
 	FlagAsync              = "async"
 	FlagJson               = "json"
 	FlagPrintResponse      = "print-response"
@@ -78,7 +79,7 @@ func PostCommands(cmds ...*cobra.Command) []*cobra.Command {
 		c.Flags().Uint64(FlagAccountNumber, 0, "AccountNumber number to sign the tx")
 		c.Flags().Uint64(FlagSequence, 0, "Sequence number to sign the tx")
 		c.Flags().String(FlagMemo, "", "Memo to send along with transaction")
-		c.Flags().String(FlagFee, "", "Fee to pay along with transaction")
+		c.Flags().String(FlagFees, "", "Fees to pay along with transaction; eg: 10stake,1atom")
 		c.Flags().String(FlagChainID, "", "Chain ID of tendermint node")
 		c.Flags().String(FlagNode, "tcp://localhost:26657", "<host>:<port> to tendermint rpc interface for this chain")
 		c.Flags().Bool(FlagUseLedger, false, "Use a connected Ledger device")
@@ -135,7 +136,7 @@ func (v *GasSetting) Type() string { return "string" }
 
 // Set parses and sets the value of the --gas flag.
 func (v *GasSetting) Set(s string) (err error) {
-	v.Simulate, v.Gas, err = ReadGasFlag(s)
+	v.Simulate, v.Gas, err = ParseGas(s)
 	return
 }
 
@@ -146,17 +147,17 @@ func (v *GasSetting) String() string {
 	return strconv.FormatUint(v.Gas, 10)
 }
 
-// ParseGasFlag parses the value of the --gas flag.
-func ReadGasFlag(s string) (simulate bool, gas uint64, err error) {
-	switch s {
+// ParseGas parses the value of the gas option.
+func ParseGas(gasStr string) (simulateAndExecute bool, gas uint64, err error) {
+	switch gasStr {
 	case "":
 		gas = DefaultGasLimit
 	case GasFlagSimulate:
-		simulate = true
+		simulateAndExecute = true
 	default:
-		gas, err = strconv.ParseUint(s, 10, 64)
+		gas, err = strconv.ParseUint(gasStr, 10, 64)
 		if err != nil {
-			err = fmt.Errorf("gas must be either integer or %q", GasFlagSimulate)
+			err = errors.New("gas must be a positive integer")
 			return
 		}
 	}